Patchwork [hglib,RESEND] hglib: fix hg clone --uncompressed option typo (issue5458)

login
register
mail settings
Submitter Long Vu
Date March 24, 2017, 2:05 p.m.
Message ID <820d7c1e470aaa11dad8.1490364325@E6230>
Download mbox | patch
Permalink /patch/19640/
State Accepted
Delegated to: Matt Mackall
Headers show

Comments

Long Vu - March 24, 2017, 2:05 p.m.
# HG changeset patch
# User Long Vu <long@tlvu.ca>
# Date 1490322881 14400
#      Thu Mar 23 22:34:41 2017 -0400
# Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
# Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
hglib: fix hg clone --uncompressed option typo (issue5458)

Was getting error.CommandError
"hg clone: option --uncompresses not recognized".
Yuya Nishihara - March 25, 2017, 4:39 a.m.
On Fri, 24 Mar 2017 10:05:25 -0400, Long Vu wrote:
> # HG changeset patch
> # User Long Vu <long@tlvu.ca>
> # Date 1490322881 14400
> #      Thu Mar 23 22:34:41 2017 -0400
> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
> hglib: fix hg clone --uncompressed option typo (issue5458)

This looks good to me.
Long Vu - March 28, 2017, 5:24 p.m.
On Sat, Mar 25, 2017 at 12:39 AM, Yuya Nishihara <yuya@tcha.org> wrote:
> On Fri, 24 Mar 2017 10:05:25 -0400, Long Vu wrote:
>> # HG changeset patch
>> # User Long Vu <long@tlvu.ca>
>> # Date 1490322881 14400
>> #      Thu Mar 23 22:34:41 2017 -0400
>> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
>> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
>> hglib: fix hg clone --uncompressed option typo (issue5458)
>
> This looks good to me.

Sorry for asking, how long before this patch will land into
https://selenic.com/repo/python-hglib?

I need to go-live soon with this patch and I'd much prefer to pull it
from the canonical source than from my personal repo.

Thanks.
Matt Mackall - April 3, 2017, 9:03 p.m.
On Fri, 2017-03-24 at 10:05 -0400, Long Vu wrote:
> # HG changeset patch
> # User Long Vu <long@tlvu.ca>
> # Date 1490322881 14400
> #      Thu Mar 23 22:34:41 2017 -0400
> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
> hglib: fix hg clone --uncompressed option typo (issue5458)

I've pushed this and made a 2.4 release, thanks.
Long Vu - April 4, 2017, 1:31 a.m.
On 2017-04-03 05:03 PM, Matt Mackall wrote:
> On Fri, 2017-03-24 at 10:05 -0400, Long Vu wrote:
>> # HG changeset patch
>> # User Long Vu <long@tlvu.ca>
>> # Date 1490322881 14400
>> #      Thu Mar 23 22:34:41 2017 -0400
>> # Node ID 820d7c1e470aaa11dad8f33e9161179a8115cef6
>> # Parent  ae38fb772613604dac7fcf63705e8a2a17ff50cd
>> hglib: fix hg clone --uncompressed option typo (issue5458)
>
> I've pushed this and made a 2.4 release, thanks.
>

Thanks Matt for also creating a release to PyPI.

Patch

diff --git a/hglib/__init__.py b/hglib/__init__.py
--- a/hglib/__init__.py
+++ b/hglib/__init__.py
@@ -28,7 +28,7 @@ 
           insecure=False, encoding=None, configs=None):
     args = util.cmdbuilder('clone', source, dest, noupdate=noupdate,
                            updaterev=updaterev, rev=rev, branch=branch,
-                           pull=pull, uncompresses=uncompressed,
+                           pull=pull, uncompressed=uncompressed,
                            e=ssh, remotecmd=remotecmd, insecure=insecure)
 
     args.insert(0, HGPATH)
diff --git a/tests/test-clone.py b/tests/test-clone.py
--- a/tests/test-clone.py
+++ b/tests/test-clone.py
@@ -11,3 +11,6 @@ 
         self.assertRaises(ValueError, cloned.log)
         cloned.open()
         self.assertEquals(self.client.log(), cloned.log())
+
+    def test_clone_uncompressed(self):
+        hglib.clone(b('.'), b('cloned'), uncompressed=True)