Patchwork [2,of,2] localrepo: deprecated '_link'

login
register
mail settings
Submitter Pierre-Yves David
Date March 15, 2017, 3:25 p.m.
Message ID <c94039261ff0af3bcc5f.1489591516@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/19365/
State Accepted
Headers show

Comments

Pierre-Yves David - March 15, 2017, 3:25 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1470399345 -7200
#      Fri Aug 05 14:15:45 2016 +0200
# Node ID c94039261ff0af3bcc5f7ff060d43eaf36a135f8
# Parent  91ac4c04240637400bb3f172fc80ff011acfcfb7
# EXP-Topic vfs.cleanup
# Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
#              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r c94039261ff0
localrepo: deprecated '_link'

That method had a total on 1 internal user...


G: changed mercurial/localrepo.py
Augie Fackler - March 16, 2017, 4:57 p.m.
On Wed, Mar 15, 2017 at 08:25:16AM -0700, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> # Date 1470399345 -7200
> #      Fri Aug 05 14:15:45 2016 +0200
> # Node ID c94039261ff0af3bcc5f7ff060d43eaf36a135f8
> # Parent  91ac4c04240637400bb3f172fc80ff011acfcfb7
> # EXP-Topic vfs.cleanup
> # Available At https://www.mercurial-scm.org/repo/users/marmoute/mercurial/
> #              hg pull https://www.mercurial-scm.org/repo/users/marmoute/mercurial/ -r c94039261ff0
> localrepo: deprecated '_link'

queued, thanks

>
> That method had a total on 1 internal user...
>
>
> G: changed mercurial/localrepo.py
>
> diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
> --- a/mercurial/localrepo.py
> +++ b/mercurial/localrepo.py
> @@ -981,6 +981,8 @@ class localrepository(object):
>          return self.wvfs(f, mode)
>
>      def _link(self, f):
> +        self.ui.deprecwarn("use 'repo.wvfs.islink' instead of 'repo._link'",
> +                           '4.0')
>          return self.wvfs.islink(f)
>
>      def _loadfilter(self, filter):
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -981,6 +981,8 @@  class localrepository(object):
         return self.wvfs(f, mode)
 
     def _link(self, f):
+        self.ui.deprecwarn("use 'repo.wvfs.islink' instead of 'repo._link'",
+                           '4.0')
         return self.wvfs.islink(f)
 
     def _loadfilter(self, filter):