Comments
Patch
@@ -137,7 +137,7 @@
# warnings
[
(r'^ [^*?/\n]* \(glob\)$',
- "warning: glob match with no glob character (?*/)"),
+ "glob match with no glob character (?*/)"),
]
]
@@ -421,6 +421,7 @@
break
for p, r in filters:
post = re.sub(p, r, post)
+ nerrs = len(pats[0]) # nerr elements are errors
if warnings:
pats = pats[0] + pats[1]
else:
@@ -432,7 +433,7 @@
prelines = None
errors = []
- for pat in pats:
+ for i, pat in enumerate(pats):
if len(pat) == 3:
p, msg, ignore = pat
else:
@@ -471,6 +472,8 @@
bl, bu, br = blamecache[n]
if bl == l:
bd = '%s@%s' % (bu, br)
+ if i >= nerrs:
+ msg = "warning: " + msg
errors.append((f, lineno and n + 1, l, msg, bd))
result = False
@@ -184,3 +184,13 @@
don't use old-style two-argument raise, use Exception(message)
[1]
+ $ cat > warning.t <<EOF
+ > $ function warnonly {
+ > > }
+ > EOF
+ $ "$check_code" warning.t
+ $ "$check_code" --warn warning.t
+ warning.t:1:
+ > $ function warnonly {
+ warning: don't use 'function', use old style
+ [1]