Patchwork [V2] hgweb: change highlighted line color to be different from 'inserted' color

login
register
mail settings
Submitter Alexander Plavin
Date July 15, 2013, 2:43 p.m.
Message ID <63c286421154f250cea1.1373899435@debian-alexander.dolgopa>
Download mbox | patch
Permalink /patch/1899/
State Accepted
Commit 5e518418738ea36e39f4d56a27a1a6e79daac983
Headers show

Comments

Alexander Plavin - July 15, 2013, 2:43 p.m.
# HG changeset patch
# User Alexander Plavin <me@aplavin.ru>
# Date 1373722313 -14400
#      Sat Jul 13 17:31:53 2013 +0400
# Node ID 63c286421154f250cea1a01458e3d505ec7532ab
# Parent  9c4770fd5940f04f7e4b2822acee4b1eb723f003
hgweb: change highlighted line color to be different from 'inserted' color

This changes line highlight color from a fain yellow (#ffff99) to
a faint blue (#bfdfff), because yellow color is used in comparison view for
inserted lines.
This new color is okay for people with different forms of color blindness
(tested with a simulator):
a) this color looks quite different from other used backgrounds
b) text doesn't lose distinction on this color
Matt Mackall - July 19, 2013, 2:17 a.m.
On Mon, 2013-07-15 at 18:43 +0400, Alexander Plavin wrote:
> # HG changeset patch
> # User Alexander Plavin <me@aplavin.ru>
> # Date 1373722313 -14400
> #      Sat Jul 13 17:31:53 2013 +0400
> # Node ID 63c286421154f250cea1a01458e3d505ec7532ab
> # Parent  9c4770fd5940f04f7e4b2822acee4b1eb723f003
> hgweb: change highlighted line color to be different from 'inserted' color

Queued for default, thanks.

Patch

diff -r 9c4770fd5940 -r 63c286421154 mercurial/templates/static/style-paper.css
--- a/mercurial/templates/static/style-paper.css	Sat Jul 13 00:57:56 2013 +0400
+++ b/mercurial/templates/static/style-paper.css	Sat Jul 13 17:31:53 2013 +0400
@@ -253,7 +253,7 @@ 
 }
 
 .sourcelines > span:target {
-  background-color: #ffff99;
+  background-color: #bfdfff;
 }
 
 .sourcelines > a {