Patchwork [6,of,7] help: use 'churn' instead of 'color' as an example extension

login
register
mail settings
Submitter Pierre-Yves David
Date Feb. 28, 2017, 7:25 p.m.
Message ID <9fffdf9b71de54fba36d.1488309946@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/18846/
State Accepted
Headers show

Comments

Pierre-Yves David - Feb. 28, 2017, 7:25 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1487714018 -3600
#      Tue Feb 21 22:53:38 2017 +0100
# Node ID 9fffdf9b71de54fba36d3efd581aa660ab8076d1
# Parent  63ff941fd53a11b8e295db36f3787f60ef0c9ceb
# EXP-Topic color
help: use 'churn' instead of 'color' as an example extension

The 'color' extensions is now deprecated.
Augie Fackler - March 1, 2017, 2:10 p.m.
> On Feb 28, 2017, at 14:25, Pierre-Yves David <pierre-yves.david@ens-lyon.org> wrote:
> 
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> # Date 1487714018 -3600
> #      Tue Feb 21 22:53:38 2017 +0100
> # Node ID 9fffdf9b71de54fba36d3efd581aa660ab8076d1
> # Parent  63ff941fd53a11b8e295db36f3787f60ef0c9ceb
> # EXP-Topic color
> help: use 'churn' instead of 'color' as an example extension
> 
> The 'color' extensions is now deprecated.
> 
> diff --git a/mercurial/help/config.txt b/mercurial/help/config.txt
> --- a/mercurial/help/config.txt
> +++ b/mercurial/help/config.txt
> @@ -728,8 +728,8 @@ or ``foo = !`` when path is not supplied
> Example for ``~/.hgrc``::
> 
>   [extensions]
> -  # (the color extension will get loaded from Mercurial's path)
> -  color =
> +  # (the churn extension will get loaded from Mercurial's path)
> +  churn =

nit: Would purge be a better thing to advertise here? Just trying to think of something that's likely to be of immediate interest to a typical user. I'm happy to send a follow-up if we've got any consensus.

(I would have said shelve, but I think I'd like to wait on that one until the implementation is a bit more robust)

>   # (this extension will get loaded from the file specified)
>   myfeature = ~/.hgext/myfeature.py
> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Pierre-Yves David - March 1, 2017, 7:35 p.m.
On 03/01/2017 03:10 PM, Augie Fackler wrote:
>
>> On Feb 28, 2017, at 14:25, Pierre-Yves David <pierre-yves.david@ens-lyon.org> wrote:
>>
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
>> # Date 1487714018 -3600
>> #      Tue Feb 21 22:53:38 2017 +0100
>> # Node ID 9fffdf9b71de54fba36d3efd581aa660ab8076d1
>> # Parent  63ff941fd53a11b8e295db36f3787f60ef0c9ceb
>> # EXP-Topic color
>> help: use 'churn' instead of 'color' as an example extension
>>
>> The 'color' extensions is now deprecated.
>>
>> diff --git a/mercurial/help/config.txt b/mercurial/help/config.txt
>> --- a/mercurial/help/config.txt
>> +++ b/mercurial/help/config.txt
>> @@ -728,8 +728,8 @@ or ``foo = !`` when path is not supplied
>> Example for ``~/.hgrc``::
>>
>>   [extensions]
>> -  # (the color extension will get loaded from Mercurial's path)
>> -  color =
>> +  # (the churn extension will get loaded from Mercurial's path)
>> +  churn =
>
> nit: Would purge be a better thing to advertise here?

'purge' can eat user data without backups. So I think we tried to keep 
an air gap between purge and clueless user that copy past thing without 
much thinking (I think it is also why it is still an extension)

> Just trying to think of something that's likely to be of immediate interest to a typical user. I'm happy to send a follow-up if we've got any consensus.

In the area of "harmless" (but less useful) I can see 'scheme' or 
'blackbox'. I seems like we are running low on extensions "so useful we 
want to push all user to enable it by default", that is probably a good 
sign overall.

> (I would have said shelve, but I think I'd like to wait on that one until the implementation is a bit more robust)

I agree, "share" would also have been a good candidate is more solid.

Cheers,

Patch

diff --git a/mercurial/help/config.txt b/mercurial/help/config.txt
--- a/mercurial/help/config.txt
+++ b/mercurial/help/config.txt
@@ -728,8 +728,8 @@  or ``foo = !`` when path is not supplied
 Example for ``~/.hgrc``::
 
   [extensions]
-  # (the color extension will get loaded from Mercurial's path)
-  color =
+  # (the churn extension will get loaded from Mercurial's path)
+  churn =
   # (this extension will get loaded from the file specified)
   myfeature = ~/.hgext/myfeature.py