Patchwork [website] downloads: add link to PPA for ubuntu/debian

login
register
mail settings
Submitter heatherboo
Date Feb. 25, 2017, 9:02 p.m.
Message ID <b91f88bda2404c91722a.1488056535@heatherboo>
Download mbox | patch
Permalink /patch/18796/
State Accepted
Headers show

Comments

heatherboo - Feb. 25, 2017, 9:02 p.m.
# HG changeset patch
# User heatherboo <heather.j.booker@gmail.com>
# Date 1488054963 28800
#      Sat Feb 25 12:36:03 2017 -0800
# Node ID b91f88bda2404c91722a62a2eb9afc63867a172b
# Parent  f8cee73d5cf0e9b4d46859c949ed0e23d65dd38c
downloads: add link to PPA for ubuntu/debian
Anton Shestakov - Feb. 26, 2017, 8:52 a.m.
On Sat, 25 Feb 2017 13:02:15 -0800
heatherboo <heather.j.booker@gmail.com> wrote:

> # HG changeset patch
> # User heatherboo <heather.j.booker@gmail.com>
> # Date 1488054963 28800
> #      Sat Feb 25 12:36:03 2017 -0800
> # Node ID b91f88bda2404c91722a62a2eb9afc63867a172b
> # Parent  f8cee73d5cf0e9b4d46859c949ed0e23d65dd38c
> downloads: add link to PPA for ubuntu/debian
> 
> diff --git a/templates/downloads/index.html b/templates/downloads/index.html
> --- a/templates/downloads/index.html
> +++ b/templates/downloads/index.html
> @@ -114,7 +114,9 @@
>      GUI the most. It integrates Mercurial directly into your explorer.</p>
>  
>      <p>Packages for common Linux, BSD and Solaris distributions can be
> -    installed from the system specific repositories</p>
> +    installed from the system specific repositories:</p>
> +    <p>(Debian/Ubuntu: If you need a more recent version than what is available through apt-get, you can <a href="https://launchpad.net/~mercurial-ppa/+archive/ubuntu/releases">try the PPA</a>.)
> +    </p>

I don't think it should recommend PPA for Debian too, because using
Ubuntu PPAs in Debian AFAIU is literally just rebuilding binary packages
from source packages. Which is easier with `make deb`.

Otherwise LGTM.
Sean Farley - March 8, 2017, 5:46 a.m.
Anton Shestakov <av6@dwimlabs.net> writes:

> On Sat, 25 Feb 2017 13:02:15 -0800
> heatherboo <heather.j.booker@gmail.com> wrote:
>
>> # HG changeset patch
>> # User heatherboo <heather.j.booker@gmail.com>
>> # Date 1488054963 28800
>> #      Sat Feb 25 12:36:03 2017 -0800
>> # Node ID b91f88bda2404c91722a62a2eb9afc63867a172b
>> # Parent  f8cee73d5cf0e9b4d46859c949ed0e23d65dd38c
>> downloads: add link to PPA for ubuntu/debian
>> 
>> diff --git a/templates/downloads/index.html b/templates/downloads/index.html
>> --- a/templates/downloads/index.html
>> +++ b/templates/downloads/index.html
>> @@ -114,7 +114,9 @@
>>      GUI the most. It integrates Mercurial directly into your explorer.</p>
>>  
>>      <p>Packages for common Linux, BSD and Solaris distributions can be
>> -    installed from the system specific repositories</p>
>> +    installed from the system specific repositories:</p>
>> +    <p>(Debian/Ubuntu: If you need a more recent version than what is available through apt-get, you can <a href="https://launchpad.net/~mercurial-ppa/+archive/ubuntu/releases">try the PPA</a>.)
>> +    </p>
>
> I don't think it should recommend PPA for Debian too, because using
> Ubuntu PPAs in Debian AFAIU is literally just rebuilding binary packages
> from source packages. Which is easier with `make deb`.
>
> Otherwise LGTM.

I didn't mind it too much but it makes sense. I'll remove 'Debian/' and queue.
Sean Farley - March 8, 2017, 5:47 a.m.
Kevin Bullock <kbullock+mercurial@ringworld.org> writes:

>> On Feb 26, 2017, at 02:52, Anton Shestakov <av6@dwimlabs.net> wrote:
>> 
>> On Sat, 25 Feb 2017 13:02:15 -0800
>> heatherboo <heather.j.booker@gmail.com> wrote:
>> 
>>> # HG changeset patch
>>> # User heatherboo <heather.j.booker@gmail.com>
>>> # Date 1488054963 28800
>>> #      Sat Feb 25 12:36:03 2017 -0800
>>> # Node ID b91f88bda2404c91722a62a2eb9afc63867a172b
>>> # Parent  f8cee73d5cf0e9b4d46859c949ed0e23d65dd38c
>>> downloads: add link to PPA for ubuntu/debian
>>> 
>>> diff --git a/templates/downloads/index.html b/templates/downloads/index.html
>>> --- a/templates/downloads/index.html
>>> +++ b/templates/downloads/index.html
>>> @@ -114,7 +114,9 @@
>>>     GUI the most. It integrates Mercurial directly into your explorer.</p>
>>> 
>>>     <p>Packages for common Linux, BSD and Solaris distributions can be
>>> -    installed from the system specific repositories</p>
>>> +    installed from the system specific repositories:</p>
>>> +    <p>(Debian/Ubuntu: If you need a more recent version than what is available through apt-get, you can <a href="https://launchpad.net/~mercurial-ppa/+archive/ubuntu/releases">try the PPA</a>.)
>>> +    </p>
>> 
>> I don't think it should recommend PPA for Debian too, because using
>> Ubuntu PPAs in Debian AFAIU is literally just rebuilding binary packages
>> from source packages. Which is easier with `make deb`.
>
> I wonder if we should also suggest backports for Debian here? I very much like the idea of having the links to more up-to-date repos in the sidebar, and instructions for `make deb` aren't likely to fit very well here.

I kinda feel as if the entire site needs a new coat of paint. Maybe we
can discuss this at the sprint.

Patch

diff --git a/templates/downloads/index.html b/templates/downloads/index.html
--- a/templates/downloads/index.html
+++ b/templates/downloads/index.html
@@ -114,7 +114,9 @@ 
     GUI the most. It integrates Mercurial directly into your explorer.</p>
 
     <p>Packages for common Linux, BSD and Solaris distributions can be
-    installed from the system specific repositories</p>
+    installed from the system specific repositories:</p>
+    <p>(Debian/Ubuntu: If you need a more recent version than what is available through apt-get, you can <a href="https://launchpad.net/~mercurial-ppa/+archive/ubuntu/releases">try the PPA</a>.)
+    </p>
     <p>
 <pre>
 # Debian/Ubuntu