Submitter | Aaron Kushner |
---|---|
Date | Feb. 23, 2017, 8:35 a.m. |
Message ID | <d81680ba42dabf6780e5.1487838925@akushner-mbp> |
Download | mbox | patch |
Permalink | /patch/18744/ |
State | Changes Requested |
Headers | show |
Comments
On Thu, 23 Feb 2017 00:35:25 -0800, Aaron Kushner wrote: > # HG changeset patch > # User Aaron Kushner <akushner@fb.com> > # Date 1487833298 28800 > # Wed Feb 22 23:01:38 2017 -0800 > # Node ID d81680ba42dabf6780e51009678a6aa809ad35bb > # Parent 96eaefd350aec869047d9e2da90913ae698463df > journal: enable pager > > The journal has been lacking pager support. > > diff --git a/hgext/journal.py b/hgext/journal.py > --- a/hgext/journal.py > +++ b/hgext/journal.py > @@ -467,6 +467,7 @@ > > limit = cmdutil.loglimit(opts) > entry = None > + ui.pager('journal') > for count, entry in enumerate(repo.journal.filtered(name=name)): Maybe we would want to see "previous locations of ..." message in pager?
On Thu, Feb 23, 2017 at 10:48:29PM +0900, Yuya Nishihara wrote: > On Thu, 23 Feb 2017 00:35:25 -0800, Aaron Kushner wrote: > > # HG changeset patch > > # User Aaron Kushner <akushner@fb.com> > > # Date 1487833298 28800 > > # Wed Feb 22 23:01:38 2017 -0800 > > # Node ID d81680ba42dabf6780e51009678a6aa809ad35bb > > # Parent 96eaefd350aec869047d9e2da90913ae698463df > > journal: enable pager > > > > The journal has been lacking pager support. > > > > diff --git a/hgext/journal.py b/hgext/journal.py > > --- a/hgext/journal.py > > +++ b/hgext/journal.py > > @@ -467,6 +467,7 @@ > > > > limit = cmdutil.loglimit(opts) > > entry = None > > + ui.pager('journal') > > for count, entry in enumerate(repo.journal.filtered(name=name)): > > Maybe we would want to see "previous locations of ..." message in pager? Probably. > _______________________________________________ > Mercurial-devel mailing list > Mercurial-devel@mercurial-scm.org > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Patch
diff --git a/hgext/journal.py b/hgext/journal.py --- a/hgext/journal.py +++ b/hgext/journal.py @@ -467,6 +467,7 @@ limit = cmdutil.loglimit(opts) entry = None + ui.pager('journal') for count, entry in enumerate(repo.journal.filtered(name=name)): if count == limit: break