Patchwork [9,of,9,pager,v2] tests: prove that ignore works

login
register
mail settings
Submitter Augie Fackler
Date Feb. 16, 2017, 4:59 p.m.
Message ID <a88d5ea0dd2855d49ada.1487264358@arthedain.pit.corp.google.com>
Download mbox | patch
Permalink /patch/18556/
State Accepted
Headers show

Comments

Augie Fackler - Feb. 16, 2017, 4:59 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1486441324 18000
#      Mon Feb 06 23:22:04 2017 -0500
# Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
# Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
tests: prove that ignore works
Simon Farnsworth - Feb. 16, 2017, 5:25 p.m.
I'm no longer seeing issues with these patches, and it'd be nice to 
reduce the pile of extensions you need to enable to get a modern 
workflow out of Hg.

On 16/02/2017 16:59, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <augie@google.com>
> # Date 1486441324 18000
> #      Mon Feb 06 23:22:04 2017 -0500
> # Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
> # Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
> tests: prove that ignore works
>
> diff --git a/tests/test-pager.t b/tests/test-pager.t
> --- a/tests/test-pager.t
> +++ b/tests/test-pager.t
> @@ -204,3 +204,21 @@ explicit flags work too:
>     8: a 8
>     9: a 9
>    10: a 10
> +
> +Put annotate in the ignore list for pager:
> +  $ cat >> $HGRCPATH <<EOF
> +  > [pager]
> +  > ignore = annotate
> +  > EOF
> +  $ hg blame a
> +   0: a
> +   1: a 1
> +   2: a 2
> +   3: a 3
> +   4: a 4
> +   5: a 5
> +   6: a 6
> +   7: a 7
> +   8: a 8
> +   9: a 9
> +  10: a 10
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=mEgSWILcY4c4W3zjApBQLA&m=CJ1L5Gx6iWAEndbgZQfzQvR8cqQ7iXJ7f9BNw2tH77I&s=zrhcVF0k6zjVEr8tds1cdSaECURlK-z9TgSyekYiFN8&e=
>
via Mercurial-devel - Feb. 16, 2017, 11:47 p.m.
On Thu, Feb 16, 2017 at 9:25 AM, Simon Farnsworth <simonfar@fb.com> wrote:
> I'm no longer seeing issues with these patches, and it'd be nice to reduce
> the pile of extensions you need to enable to get a modern workflow out of
> Hg.

Besides the nits on patch 3/9, this is looking great to me too. Thanks!

>
>
> On 16/02/2017 16:59, Augie Fackler wrote:
>>
>> # HG changeset patch
>> # User Augie Fackler <augie@google.com>
>> # Date 1486441324 18000
>> #      Mon Feb 06 23:22:04 2017 -0500
>> # Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
>> # Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
>> tests: prove that ignore works
>>
>> diff --git a/tests/test-pager.t b/tests/test-pager.t
>> --- a/tests/test-pager.t
>> +++ b/tests/test-pager.t
>> @@ -204,3 +204,21 @@ explicit flags work too:
>>     8: a 8
>>     9: a 9
>>    10: a 10
>> +
>> +Put annotate in the ignore list for pager:
>> +  $ cat >> $HGRCPATH <<EOF
>> +  > [pager]
>> +  > ignore = annotate
>> +  > EOF
>> +  $ hg blame a
>> +   0: a
>> +   1: a 1
>> +   2: a 2
>> +   3: a 3
>> +   4: a 4
>> +   5: a 5
>> +   6: a 6
>> +   7: a 7
>> +   8: a 8
>> +   9: a 9
>> +  10: a 10
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel@mercurial-scm.org
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=mEgSWILcY4c4W3zjApBQLA&m=CJ1L5Gx6iWAEndbgZQfzQvR8cqQ7iXJ7f9BNw2tH77I&s=zrhcVF0k6zjVEr8tds1cdSaECURlK-z9TgSyekYiFN8&e=
>>
>
> --
> Simon Farnsworth
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Martin von Zweigbergk - Feb. 17, 2017, 4:54 p.m.
On Thu, Feb 16, 2017 at 3:47 PM, Martin von Zweigbergk
<martinvonz@google.com> wrote:
> On Thu, Feb 16, 2017 at 9:25 AM, Simon Farnsworth <simonfar@fb.com> wrote:
>> I'm no longer seeing issues with these patches, and it'd be nice to reduce
>> the pile of extensions you need to enable to get a modern workflow out of
>> Hg.
>
> Besides the nits on patch 3/9, this is looking great to me too. Thanks!

Since those were just about style and I think you'll be out for a day
or a few, I've pushed the current iteration to "committed", but please
address the comments on patch 3/9 when you're back (explaining why the
comments make no sense is of course a valid way; patches may not even
be necessary). Thanks!

>
>>
>>
>> On 16/02/2017 16:59, Augie Fackler wrote:
>>>
>>> # HG changeset patch
>>> # User Augie Fackler <augie@google.com>
>>> # Date 1486441324 18000
>>> #      Mon Feb 06 23:22:04 2017 -0500
>>> # Node ID a88d5ea0dd2855d49adae8a6c820e278ec594512
>>> # Parent  4c2f3f1b67a71401faff082dbca79a3f212b5499
>>> tests: prove that ignore works
>>>
>>> diff --git a/tests/test-pager.t b/tests/test-pager.t
>>> --- a/tests/test-pager.t
>>> +++ b/tests/test-pager.t
>>> @@ -204,3 +204,21 @@ explicit flags work too:
>>>     8: a 8
>>>     9: a 9
>>>    10: a 10
>>> +
>>> +Put annotate in the ignore list for pager:
>>> +  $ cat >> $HGRCPATH <<EOF
>>> +  > [pager]
>>> +  > ignore = annotate
>>> +  > EOF
>>> +  $ hg blame a
>>> +   0: a
>>> +   1: a 1
>>> +   2: a 2
>>> +   3: a 3
>>> +   4: a 4
>>> +   5: a 5
>>> +   6: a 6
>>> +   7: a 7
>>> +   8: a 8
>>> +   9: a 9
>>> +  10: a 10
>>> _______________________________________________
>>> Mercurial-devel mailing list
>>> Mercurial-devel@mercurial-scm.org
>>>
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=mEgSWILcY4c4W3zjApBQLA&m=CJ1L5Gx6iWAEndbgZQfzQvR8cqQ7iXJ7f9BNw2tH77I&s=zrhcVF0k6zjVEr8tds1cdSaECURlK-z9TgSyekYiFN8&e=
>>>
>>
>> --
>> Simon Farnsworth
>>
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel@mercurial-scm.org
>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -204,3 +204,21 @@  explicit flags work too:
    8: a 8
    9: a 9
   10: a 10
+
+Put annotate in the ignore list for pager:
+  $ cat >> $HGRCPATH <<EOF
+  > [pager]
+  > ignore = annotate
+  > EOF
+  $ hg blame a
+   0: a
+   1: a 1
+   2: a 2
+   3: a 3
+   4: a 4
+   5: a 5
+   6: a 6
+   7: a 7
+   8: a 8
+   9: a 9
+  10: a 10