Patchwork [6,of,9,pager,v2] ui: respect historic pager.attend-$COMMAND=no

login
register
mail settings
Submitter Augie Fackler
Date Feb. 16, 2017, 4:59 p.m.
Message ID <35d0605a6304ad215260.1487264355@arthedain.pit.corp.google.com>
Download mbox | patch
Permalink /patch/18553/
State Accepted
Headers show

Comments

Augie Fackler - Feb. 16, 2017, 4:59 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1486442524 18000
#      Mon Feb 06 23:42:04 2017 -0500
# Node ID 35d0605a6304ad2152603f480c7190839907e4cf
# Parent  f57d6104f362edca58dbb5c5434ee8d668a92777
ui: respect historic pager.attend-$COMMAND=no

I'm on the fence about this behavior, but the user's intent was pretty
specific and it's not expensive to support this case.

Patch

diff --git a/mercurial/ui.py b/mercurial/ui.py
--- a/mercurial/ui.py
+++ b/mercurial/ui.py
@@ -857,6 +857,7 @@  class ui(object):
         if (self._neverpager
             or self.pageractive
             or command in self.configlist('pager', 'ignore')
+            or not self.configbool('pager', 'attend-' + command, True)
             # TODO: if we want to allow HGPLAINEXCEPT=pager,
             # formatted() will need some adjustment.
             or not self.formatted()