Patchwork [3,of,6] debugcommands: move 'debuglabelcomplete' in the new module

login
register
mail settings
Submitter Augie Fackler
Date Feb. 13, 2017, 8:27 p.m.
Message ID <883BE953-190D-44A8-AE9E-1148520F495E@durin42.com>
Download mbox | patch
Permalink /patch/18453/
State Changes Requested
Headers show

Comments

Augie Fackler - Feb. 13, 2017, 8:27 p.m.
> On Feb 13, 2017, at 15:22, Augie Fackler <raf@durin42.com> wrote:
> 
> 
>> On Feb 13, 2017, at 14:24, Augie Fackler <raf@durin42.com> wrote:
>> 
>>> Meant to be removed from commands.py too, right?
>> 
>> Looks like it. I've queued patches 1,2, 4-6 of this series, we can get
>> this one on a resend.
> 
> Sigh. I'm getting test-completion.t failures with these applied, so I'm going to discard them for now.


Specifically:


ERROR: test-completion.t output changed

So I've discarded these three (the rest of the series doesn't irritate the test):

99d4ae09 o draft debugcommands: move 'debuglocks' in the new module
         |
7fd152b1 o draft debugcommands: move 'debugnamecomplete' in the new module
         |
358a9971 o draft debugcommands: move 'debugmergestate' in the new module
Pierre-Yves David - Feb. 14, 2017, 3:37 p.m.
On 02/13/2017 09:27 PM, Augie Fackler wrote:
>
>> On Feb 13, 2017, at 15:22, Augie Fackler <raf@durin42.com> wrote:
>>
>>
>>> On Feb 13, 2017, at 14:24, Augie Fackler <raf@durin42.com> wrote:
>>>
>>>> Meant to be removed from commands.py too, right?

Yep, Good catch

>>> Looks like it. I've queued patches 1,2, 4-6 of this series, we can get
>>> this one on a resend.
>>
>> Sigh. I'm getting test-completion.t failures with these applied, so I'm going to discard them for now.
>
>
> Specifically:
>
> --- /home/augie/hg/tests/test-completion.t
> +++ /home/augie/hg/tests/test-completion.t.err
> @@ -92,7 +92,6 @@
>    debugindexdot
>    debuginstall
>    debugknown
> -  debuglabelcomplete
>    debuglocks
>    debugmergestate
>    debugnamecomplete


The removal of 'debuglabelcomplete' in 'command.py' migrated from the 
intended patch to the one afterward. So dropping that patch without the 
next one lead to the full disappearing of the commands. V2 is on the way.

Patch

--- /home/augie/hg/tests/test-completion.t
+++ /home/augie/hg/tests/test-completion.t.err
@@ -92,7 +92,6 @@ 
   debugindexdot
   debuginstall
   debugknown
-  debuglabelcomplete
   debuglocks
   debugmergestate
   debugnamecomplete
@@ -258,7 +257,6 @@ 
   debugindexdot: changelog, manifest, dir
   debuginstall: template
   debugknown:
-  debuglabelcomplete:
   debuglocks: force-lock, force-wlock
   debugmergestate:
   debugnamecomplete: