Patchwork [3,of,6] debugcommands: move 'debuglabelcomplete' in the new module

login
register
mail settings
Submitter Pierre-Yves David
Date Feb. 13, 2017, 4:07 p.m.
Message ID <efbf6a59699575d328d7.1487002033@nodosa.octopoid.net>
Download mbox | patch
Permalink /patch/18439/
State Accepted
Headers show

Comments

Pierre-Yves David - Feb. 13, 2017, 4:07 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1485967171 -3600
#      Wed Feb 01 17:39:31 2017 +0100
# Node ID efbf6a59699575d328d71a6cdcb9a8db25a85c6e
# Parent  f25d7b04bb99f20965efa0bf042b485d8bcd58b8
# EXP-Topic debugcommands
debugcommands: move 'debuglabelcomplete' in the new module
via Mercurial-devel - Feb. 13, 2017, 5:43 p.m.
On Mon, Feb 13, 2017 at 8:07 AM, Pierre-Yves David
<pierre-yves.david@ens-lyon.org> wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> # Date 1485967171 -3600
> #      Wed Feb 01 17:39:31 2017 +0100
> # Node ID efbf6a59699575d328d71a6cdcb9a8db25a85c6e
> # Parent  f25d7b04bb99f20965efa0bf042b485d8bcd58b8
> # EXP-Topic debugcommands
> debugcommands: move 'debuglabelcomplete' in the new module
>
> diff -r f25d7b04bb99 -r efbf6a596995 mercurial/debugcommands.py
> --- a/mercurial/debugcommands.py        Wed Feb 01 17:33:46 2017 +0100
> +++ b/mercurial/debugcommands.py        Wed Feb 01 17:39:31 2017 +0100
> @@ -1036,6 +1036,11 @@ def debugknown(ui, repopath, *ids, **opt
>      flags = repo.known([bin(s) for s in ids])
>      ui.write("%s\n" % ("".join([f and "1" or "0" for f in flags])))
>
> +@command('debuglabelcomplete', [], _('LABEL...'))
> +def debuglabelcomplete(ui, repo, *args):
> +    '''backwards compatibility with old bash completion scripts (DEPRECATED)'''
> +    commands.debugnamecomplete(ui, repo, *args)
> +

Meant to be removed from commands.py too, right?

>  @command('debugupgraderepo', [
>      ('o', 'optimize', [], _('extra optimization to perform'), _('NAME')),
>      ('', 'run', False, _('performs an upgrade')),
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Augie Fackler - Feb. 13, 2017, 7:24 p.m.
On Mon, Feb 13, 2017 at 09:43:05AM -0800, Martin von Zweigbergk via Mercurial-devel wrote:
> On Mon, Feb 13, 2017 at 8:07 AM, Pierre-Yves David
> <pierre-yves.david@ens-lyon.org> wrote:
> > # HG changeset patch
> > # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> > # Date 1485967171 -3600
> > #      Wed Feb 01 17:39:31 2017 +0100
> > # Node ID efbf6a59699575d328d71a6cdcb9a8db25a85c6e
> > # Parent  f25d7b04bb99f20965efa0bf042b485d8bcd58b8
> > # EXP-Topic debugcommands
> > debugcommands: move 'debuglabelcomplete' in the new module
> >
> > diff -r f25d7b04bb99 -r efbf6a596995 mercurial/debugcommands.py
> > --- a/mercurial/debugcommands.py        Wed Feb 01 17:33:46 2017 +0100
> > +++ b/mercurial/debugcommands.py        Wed Feb 01 17:39:31 2017 +0100
> > @@ -1036,6 +1036,11 @@ def debugknown(ui, repopath, *ids, **opt
> >      flags = repo.known([bin(s) for s in ids])
> >      ui.write("%s\n" % ("".join([f and "1" or "0" for f in flags])))
> >
> > +@command('debuglabelcomplete', [], _('LABEL...'))
> > +def debuglabelcomplete(ui, repo, *args):
> > +    '''backwards compatibility with old bash completion scripts (DEPRECATED)'''
> > +    commands.debugnamecomplete(ui, repo, *args)
> > +
>
> Meant to be removed from commands.py too, right?

Looks like it. I've queued patches 1,2, 4-6 of this series, we can get
this one on a resend.

>
> >  @command('debugupgraderepo', [
> >      ('o', 'optimize', [], _('extra optimization to perform'), _('NAME')),
> >      ('', 'run', False, _('performs an upgrade')),
> > _______________________________________________
> > Mercurial-devel mailing list
> > Mercurial-devel@mercurial-scm.org
> > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Augie Fackler - Feb. 13, 2017, 8:22 p.m.
> On Feb 13, 2017, at 14:24, Augie Fackler <raf@durin42.com> wrote:
> 
>> Meant to be removed from commands.py too, right?
> 
> Looks like it. I've queued patches 1,2, 4-6 of this series, we can get
> this one on a resend.

Sigh. I'm getting test-completion.t failures with these applied, so I'm going to discard them for now.

Patch

diff -r f25d7b04bb99 -r efbf6a596995 mercurial/debugcommands.py
--- a/mercurial/debugcommands.py	Wed Feb 01 17:33:46 2017 +0100
+++ b/mercurial/debugcommands.py	Wed Feb 01 17:39:31 2017 +0100
@@ -1036,6 +1036,11 @@  def debugknown(ui, repopath, *ids, **opt
     flags = repo.known([bin(s) for s in ids])
     ui.write("%s\n" % ("".join([f and "1" or "0" for f in flags])))
 
+@command('debuglabelcomplete', [], _('LABEL...'))
+def debuglabelcomplete(ui, repo, *args):
+    '''backwards compatibility with old bash completion scripts (DEPRECATED)'''
+    commands.debugnamecomplete(ui, repo, *args)
+
 @command('debugupgraderepo', [
     ('o', 'optimize', [], _('extra optimization to perform'), _('NAME')),
     ('', 'run', False, _('performs an upgrade')),