Patchwork [1,of,3,pager-in-core-prep] pager: add a test of --pager=no functionality

login
register
mail settings
Submitter Augie Fackler
Date Feb. 7, 2017, 10:20 p.m.
Message ID <f95d0ac806b945d821ca.1486506017@arthedain.pit.corp.google.com>
Download mbox | patch
Permalink /patch/18342/
State Accepted
Delegated to: Martin von Zweigbergk
Headers show

Comments

Augie Fackler - Feb. 7, 2017, 10:20 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1486433735 18000
#      Mon Feb 06 21:15:35 2017 -0500
# Node ID f95d0ac806b945d821ca131a2e59b7cf778bcd5a
# Parent  a68510b69f413545722c086eaeb840dd5e8305b4
pager: add a test of --pager=no functionality

I'm about to upend the pager universe, but I would like to not regress
anything.
Augie Fackler - Feb. 7, 2017, 10:23 p.m.
These three patches are the prep work for a long series that moves
pager to core and makes it on by default. If you want to see where I'm
going here, please look at:

https://hg.durin42.com/hg-wip/log?revcount=50&rev=%40%3A%3Apager+-+%40

It's probably worth calling out that I don't have a really great way
in mind to split that series, so it's probably worth someone's time to
eyeball things in advance a bit.

On Tue, Feb 7, 2017 at 5:20 PM, Augie Fackler <raf@durin42.com> wrote:
> # HG changeset patch
> # User Augie Fackler <augie@google.com>
> # Date 1486433735 18000
> #      Mon Feb 06 21:15:35 2017 -0500
> # Node ID f95d0ac806b945d821ca131a2e59b7cf778bcd5a
> # Parent  a68510b69f413545722c086eaeb840dd5e8305b4
> pager: add a test of --pager=no functionality
>
> I'm about to upend the pager universe, but I would like to not regress
> anything.
>
> diff --git a/tests/test-pager.t b/tests/test-pager.t
> --- a/tests/test-pager.t
> +++ b/tests/test-pager.t
> @@ -207,6 +207,11 @@ Pager works with hg aliases including en
>    $ A=2 hg --config pager.attend-printa=yes printa
>    paged! '2\n'
>
> +Something that's explicitly attended is still not paginated if the
> +pager is globally set to off using a flag:
> +  $ A=2 hg --config pager.attend-printa=yes printa --pager=no
> +  2
> +
>  Pager should not override the exit code of other commands
>
>    $ cat >> $TESTTMP/fortytwo.py <<'EOF'
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Bryan O'Sullivan - Feb. 8, 2017, 10:18 p.m.
On Tue, Feb 7, 2017 at 2:23 PM, Augie Fackler <raf@durin42.com> wrote:

> These three patches are the prep work for a long series that moves
> pager to core and makes it on by default.
>

These 3 look good. Thanks!
Bryan O'Sullivan - Feb. 8, 2017, 10:20 p.m.
On Tue, Feb 7, 2017 at 2:23 PM, Augie Fackler <raf@durin42.com> wrote:

> It's probably worth calling out that I don't have a really great way
> in mind to split that series, so it's probably worth someone's time to
> eyeball things in advance a bit.
>

I took a look over that stack, and it all looks quite reasonable and
well-factored.

Patch

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -207,6 +207,11 @@  Pager works with hg aliases including en
   $ A=2 hg --config pager.attend-printa=yes printa
   paged! '2\n'
 
+Something that's explicitly attended is still not paginated if the
+pager is globally set to off using a flag:
+  $ A=2 hg --config pager.attend-printa=yes printa --pager=no
+  2
+
 Pager should not override the exit code of other commands
 
   $ cat >> $TESTTMP/fortytwo.py <<'EOF'