Patchwork [1,of,3,stable] tests: expand flags to long form in test-largefiles-update.t

login
register
mail settings
Submitter Augie Fackler
Date Jan. 30, 2017, 11:54 p.m.
Message ID <d717001c36eb9d184b6c.1485820456@imladris.local>
Download mbox | patch
Permalink /patch/18286/
State Accepted
Headers show

Comments

Augie Fackler - Jan. 30, 2017, 11:54 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1485817041 18000
#      Mon Jan 30 17:57:21 2017 -0500
# Branch stable
# Node ID d717001c36eb9d184b6c83874feb600adc22e8e7
# Parent  312b861924c89716d9bdd28dd8698665ef6d0498
tests: expand flags to long form in test-largefiles-update.t

I spent some time confused by this test. I'm pretty sure that this
line intends to be cleaning the dirstate, not checking that it's clean
before updating: the preceding #if block leaves the dirstate clean in
the noexec case, and dirty in the exec case, so we can't expect
consistent behavior across that platform variation. A subsequent patch
will modify this command to use --clean instead of --check.

I'll elaborate in that patch about the hypothetical bug here.

Patch

diff --git a/tests/test-largefiles-update.t b/tests/test-largefiles-update.t
--- a/tests/test-largefiles-update.t
+++ b/tests/test-largefiles-update.t
@@ -737,7 +737,7 @@  files correctly after an interrupted upd
 hashes reveals it isn't clean.
 
 Start with clean dirstates:
-  $ hg up -qcr "8^"
+  $ hg up --quiet --check --rev "8^"
   $ sleep 1
   $ hg st
 Update standins without updating largefiles - large1 is modified and largeX is