Patchwork [2,of,3] help: don't let tools reflow revlog flags list

login
register
mail settings
Submitter via Mercurial-devel
Date Jan. 17, 2017, 8:10 p.m.
Message ID <7e933c9a4009d942b88b.1484683830@martinvonz.mtv.corp.google.com>
Download mbox | patch
Permalink /patch/18239/
State Accepted
Headers show

Comments

via Mercurial-devel - Jan. 17, 2017, 8:10 p.m.
# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 1484682310 28800
#      Tue Jan 17 11:45:10 2017 -0800
# Node ID 7e933c9a4009d942b88bfbcb4e579a4b3f4dceca
# Parent  2fa3f64c5bf451e7623ee7bb294ac35f9b2228a3
help: don't let tools reflow revlog flags list

Before this change, the text about revlog flags was reflowed into a
single paragraph, which made it a bit hard to read. I don't even know
the rules around this, but adding a blank line before each flag seems
to prevent the reflowing.
Pierre-Yves David - Jan. 17, 2017, 9:34 p.m.
On 01/17/2017 09:10 PM, Martin von Zweigbergk via Mercurial-devel wrote:
> # HG changeset patch
> # User Martin von Zweigbergk <martinvonz@google.com>
> # Date 1484682310 28800
> #      Tue Jan 17 11:45:10 2017 -0800
> # Node ID 7e933c9a4009d942b88bfbcb4e579a4b3f4dceca
> # Parent  2fa3f64c5bf451e7623ee7bb294ac35f9b2228a3
> help: don't let tools reflow revlog flags list
>
> Before this change, the text about revlog flags was reflowed into a
> single paragraph, which made it a bit hard to read. I don't even know
> the rules around this, but adding a blank line before each flag seems
> to prevent the reflowing.

Patches 1 and 2 are obviously good, I've pushed them.
Comment on patch 3 coming

>
> diff -r 2fa3f64c5bf4 -r 7e933c9a4009 mercurial/help/internals/revlogs.txt
> --- a/mercurial/help/internals/revlogs.txt	Tue Jan 17 11:29:06 2017 -0800
> +++ b/mercurial/help/internals/revlogs.txt	Tue Jan 17 11:45:10 2017 -0800
> @@ -91,7 +91,9 @@
>
>  6-7 (2 bytes)
>     Bit flags impacting revision behavior. The following bit offsets define:
> +
>     0: REVIDX_ISCENSORED revision has censor metadata, must be verified.
> +
>     1: REVIDX_EXTSTORED revision data is stored externally.
>
>  8-11 (4 bytes)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>

Patch

diff -r 2fa3f64c5bf4 -r 7e933c9a4009 mercurial/help/internals/revlogs.txt
--- a/mercurial/help/internals/revlogs.txt	Tue Jan 17 11:29:06 2017 -0800
+++ b/mercurial/help/internals/revlogs.txt	Tue Jan 17 11:45:10 2017 -0800
@@ -91,7 +91,9 @@ 
 
 6-7 (2 bytes)
    Bit flags impacting revision behavior. The following bit offsets define:
+
    0: REVIDX_ISCENSORED revision has censor metadata, must be verified.
+
    1: REVIDX_EXTSTORED revision data is stored externally.
 
 8-11 (4 bytes)