Patchwork [4,of,4,flagprocessor,v11] revlog: REVIDX_EXTSTORED flag

login
register
mail settings
Submitter Remi Chaintron
Date Jan. 10, 2017, 5:16 p.m.
Message ID <5f8a0a7d806646ba0c00.1484068610@remi-mbp2>
Download mbox | patch
Permalink /patch/18172/
State Accepted
Headers show

Comments

Remi Chaintron - Jan. 10, 2017, 5:16 p.m.
# HG changeset patch
# User Remi Chaintron <remi@fb.com>
# Date 1483636611 0
#      Thu Jan 05 17:16:51 2017 +0000
# Node ID 5f8a0a7d806646ba0c000c05db72f542d7482507
# Parent  77b07852217ed3ca0573140e9d76d0432894f3a1
revlog: REVIDX_EXTSTORED flag

This flag will be used by the lfs extension to mark the revision data as stored
externally.
Pierre-Yves David - Jan. 10, 2017, 6 p.m.
On 01/10/2017 06:16 PM, Remi Chaintron wrote:
> # HG changeset patch
> # User Remi Chaintron <remi@fb.com>
> # Date 1483636611 0
> #      Thu Jan 05 17:16:51 2017 +0000
> # Node ID 5f8a0a7d806646ba0c000c05db72f542d7482507
> # Parent  77b07852217ed3ca0573140e9d76d0432894f3a1
> revlog: REVIDX_EXTSTORED flag

That series is pushed with a small inflight fix to appease
test-check-commit.t. Thanks,

(I'm not a fan of that bitsfrom function added to utils since it only 
has one caller but lets move forward)

Cheers

Patch

diff --git a/mercurial/help/internals/revlogs.txt b/mercurial/help/internals/revlogs.txt
--- a/mercurial/help/internals/revlogs.txt
+++ b/mercurial/help/internals/revlogs.txt
@@ -90,6 +90,7 @@ 
 6-7 (2 bytes)
    Bit flags impacting revision behavior. The following bit offsets define:
    0: REVIDX_ISCENSORED revision has censor metadata, must be verified.
+   1: REVIDX_EXTSTORED revision data is stored externally.
 8-11 (4 bytes)
    Compressed length of revision data / chunk as stored in revlog.
 12-15 (4 bytes)
diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -54,10 +54,12 @@ 
 
 # revlog index flags
 REVIDX_ISCENSORED = (1 << 15) # revision has censor metadata, must be verified
+REVIDX_EXTSTORED = (1 << 14) # revision data is stored externally
 REVIDX_DEFAULT_FLAGS = 0
 # stable order in which flags need to be processed and their processors applied
 REVIDX_FLAGS_ORDER = [
     REVIDX_ISCENSORED,
+    REVIDX_EXTSTORED,
 ]
 REVIDX_KNOWN_FLAGS = util.bitsfrom(REVIDX_FLAGS_ORDER)