Patchwork [V2] setup: pass named argument to setup_zstd

login
register
mail settings
Submitter Gregory Szorc
Date Jan. 5, 2017, 3:18 a.m.
Message ID <7242afc7fe15bd46ec7b.1483586283@ubuntu-vm-main>
Download mbox | patch
Permalink /patch/18097/
State Accepted
Headers show

Comments

Gregory Szorc - Jan. 5, 2017, 3:18 a.m.
# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1483586264 28800
#      Wed Jan 04 19:17:44 2017 -0800
# Node ID 7242afc7fe15bd46ec7bde353def34c0e39a20ec
# Parent  13d94304c8daa1fea0551ffb39b2ca3da40e92d7
setup: pass named argument to setup_zstd

The next release from upstream adds another named argument to this
function. Specify arguments by name so there is no ambiguity about
which argument is being passed.
Pierre-Yves David - Jan. 5, 2017, 11:04 a.m.
On 01/05/2017 04:18 AM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc@gmail.com>
> # Date 1483586264 28800
> #      Wed Jan 04 19:17:44 2017 -0800
> # Node ID 7242afc7fe15bd46ec7bde353def34c0e39a20ec
> # Parent  13d94304c8daa1fea0551ffb39b2ca3da40e92d7
> setup: pass named argument to setup_zstd

Pushed, thanks.

Patch

diff --git a/setup.py b/setup.py
--- a/setup.py
+++ b/setup.py
@@ -615,7 +615,7 @@  extmodules = [
 
 sys.path.insert(0, 'contrib/python-zstandard')
 import setup_zstd
-extmodules.append(setup_zstd.get_c_extension('mercurial.zstd'))
+extmodules.append(setup_zstd.get_c_extension(name='mercurial.zstd'))
 
 try:
     from distutils import cygwinccompiler