Patchwork [v2] tests: add magic string to bypass check-commit

login
register
mail settings
Submitter David Soria Parra
Date Dec. 21, 2016, 9:44 p.m.
Message ID <dba02153520bf599a723.1482356688@devbig415.prn1.facebook.com>
Download mbox | patch
Permalink /patch/17993/
State Accepted
Headers show

Comments

David Soria Parra - Dec. 21, 2016, 9:44 p.m.
# HG changeset patch
# User David Soria Parra <davidsp@fb.com>
# Date 1482356655 28800
#      Wed Dec 21 13:44:15 2016 -0800
# Node ID dba02153520bf599a723a6641a8040c7966d2226
# Parent  392751cbb6c47a43676e324d2f1a4e45f35e624b
tests: add magic string to bypass check-commit

Allow bypassing test-check-commit runs by specifying '# no-check-commit'
in the description. This should be avoided but is useful for upstream
imports such as pywatchman which will cause check-code to fail otherwise.
Pierre-Yves David - Dec. 22, 2016, 10:57 a.m.
On 12/21/2016 10:44 PM, David Soria Parra wrote:
> # HG changeset patch
> # User David Soria Parra <davidsp@fb.com>
> # Date 1482356655 28800
> #      Wed Dec 21 13:44:15 2016 -0800
> # Node ID dba02153520bf599a723a6641a8040c7966d2226
> # Parent  392751cbb6c47a43676e324d2f1a4e45f35e624b
> tests: add magic string to bypass check-commit
>
> Allow bypassing test-check-commit runs by specifying '# no-check-commit'
> in the description. This should be avoided but is useful for upstream
> imports such as pywatchman which will cause check-code to fail otherwise.

That is a good improvement over the current situation. Thanks for 
tackling that.

I don't think the lack of "start of line" will be too much of an issue. 
If it ever become some we'll improve the check then.

Cheers.

Patch

diff --git a/tests/test-check-commit.t b/tests/test-check-commit.t
--- a/tests/test-check-commit.t
+++ b/tests/test-check-commit.t
@@ -8,7 +8,7 @@ 
 
   $ cd $TESTDIR/..
 
-  $ for node in `hg log --rev 'not public() and ::.' --template '{node|short}\n'`; do
+  $ for node in `hg log --rev 'not public() and ::. and not desc("# no-check-commit")' --template '{node|short}\n'`; do
   >    hg export $node | contrib/check-commit > ${TESTTMP}/check-commit.out
   >    if [ $? -ne 0 ]; then
   >        echo "Revision $node does not comply with rules"