Patchwork [2,of,2,hg-website] menu: capitalize the menu options in nav bar

login
register
mail settings
Submitter Pulkit Goyal
Date Dec. 8, 2016, 8:23 a.m.
Message ID <39b44ed32913cc10bcc9.1481185430@pulkit-goyal>
Download mbox | patch
Permalink /patch/17875/
State Accepted
Headers show

Comments

Pulkit Goyal - Dec. 8, 2016, 8:23 a.m.
# HG changeset patch
# User Pulkit Goyal <7895pulkit@gmail.com>
# Date 1481185128 -19800
#      Thu Dec 08 13:48:48 2016 +0530
# Node ID 39b44ed32913cc10bcc93115286262f080a257fb
# Parent  5d30d7a345692b6656b60c9f4dab86f012b391eb
menu: capitalize the menu options in nav bar

This patch capitalize the first letter of the options in nav bar.
Sean Farley - Dec. 8, 2016, 6:46 p.m.
Pulkit Goyal <7895pulkit@gmail.com> writes:

> # HG changeset patch
> # User Pulkit Goyal <7895pulkit@gmail.com>
> # Date 1481185128 -19800
> #      Thu Dec 08 13:48:48 2016 +0530
> # Node ID 39b44ed32913cc10bcc93115286262f080a257fb
> # Parent  5d30d7a345692b6656b60c9f4dab86f012b391eb
> menu: capitalize the menu options in nav bar
>
> This patch capitalize the first letter of the options in nav bar.

Thanks! I'm a bit busy today but will try to swing back around to this
later.
Pierre-Yves David - Dec. 19, 2016, 3:27 p.m.
On 12/08/2016 07:46 PM, Sean Farley wrote:
> Pulkit Goyal <7895pulkit@gmail.com> writes:
>
>> # HG changeset patch
>> # User Pulkit Goyal <7895pulkit@gmail.com>
>> # Date 1481185128 -19800
>> #      Thu Dec 08 13:48:48 2016 +0530
>> # Node ID 39b44ed32913cc10bcc93115286262f080a257fb
>> # Parent  5d30d7a345692b6656b60c9f4dab86f012b391eb
>> menu: capitalize the menu options in nav bar
>>
>> This patch capitalize the first letter of the options in nav bar.
>
> Thanks! I'm a bit busy today but will try to swing back around to this
> later.

It looks like they never made it to the website repository. Sean, do 
you have time to look at them this week or do you want someone to have a 
look?

Cheers
Sean Farley - Dec. 20, 2016, 7:19 p.m.
Sean Farley <sean@farley.io> writes:

> Pulkit Goyal <7895pulkit@gmail.com> writes:
>
>> # HG changeset patch
>> # User Pulkit Goyal <7895pulkit@gmail.com>
>> # Date 1481185128 -19800
>> #      Thu Dec 08 13:48:48 2016 +0530
>> # Node ID 39b44ed32913cc10bcc93115286262f080a257fb
>> # Parent  5d30d7a345692b6656b60c9f4dab86f012b391eb
>> menu: capitalize the menu options in nav bar
>>
>> This patch capitalize the first letter of the options in nav bar.
>
> Thanks! I'm a bit busy today but will try to swing back around to this
> later.

Finally got around to this. I am no UI expert but think it looks better
:-)

Queued (and now pushed)!

Patch

diff -r 5d30d7a34569 -r 39b44ed32913 templates/base.html
--- a/templates/base.html	Thu Dec 08 13:45:16 2016 +0530
+++ b/templates/base.html	Thu Dec 08 13:48:48 2016 +0530
@@ -19,11 +19,11 @@ 
         <h1 id="logo"><a href="/">mercurial</a></h1>
             
         <ul id="nav">
-            <li><a href="/about">about</a></li>
-            <li><a href="/guide">guide</a></li>
-            <li><a href="/downloads">download</a></li>
-            <li><a href="https://www.mercurial-scm.org/wiki/UsingExtensions">extensions</a></li>
-            <li><a href="https://www.mercurial-scm.org/wiki/">news/wiki</a></li>
+            <li><a href="/about">About</a></li>
+            <li><a href="/guide">Guide</a></li>
+            <li><a href="/downloads">Download</a></li>
+            <li><a href="https://www.mercurial-scm.org/wiki/UsingExtensions">Extensions</a></li>
+            <li><a href="https://www.mercurial-scm.org/wiki/">News/Wiki</a></li>
         </ul>
         
         <form id="search" method="get" action="https://www.mercurial-scm.org/wiki/Mercurial">