Patchwork [1,of,6,v2,convert] Use convert_revision for P4 imports

login
register
mail settings
Submitter David Soria Parra
Date Dec. 7, 2016, 9:30 p.m.
Message ID <ade3103f5cf939007ca7.1481146243@devbig415.prn1.facebook.com>
Download mbox | patch
Permalink /patch/17867/
State Superseded
Headers show

Comments

David Soria Parra - Dec. 7, 2016, 9:30 p.m.
# HG changeset patch
# User David Soria Parra <davidsp@fb.com>
# Date 1480895549 28800
#      Sun Dec 04 15:52:29 2016 -0800
# Node ID ade3103f5cf939007ca73af5e9e5853643dc8264
# Parent  48bf03a8f718f870256f79cbdf10550ca92c7f25
[convert] Use convert_revision for P4 imports

We are using convert_revisions in other importers. In order to unify this
we are also using convert_revision for Perforce in addition to the original
'p4'.
Kostia Balytskyi - Dec. 7, 2016, 9:48 p.m.
On 12/7/16 9:30 PM, David Soria Parra wrote:
> # HG changeset patch

> # User David Soria Parra <davidsp@fb.com>

> # Date 1480895549 28800

> #      Sun Dec 04 15:52:29 2016 -0800

> # Node ID ade3103f5cf939007ca73af5e9e5853643dc8264

> # Parent  48bf03a8f718f870256f79cbdf10550ca92c7f25

> [convert] Use convert_revision for P4 imports

This does not follow our naming scheme "keyword: some short description"
>

> We are using convert_revisions in other importers. In order to unify this

> we are also using convert_revision for Perforce in addition to the original

> 'p4'.

>

> diff --git a/hgext/convert/p4.py b/hgext/convert/p4.py

> --- a/hgext/convert/p4.py

> +++ b/hgext/convert/p4.py

> @@ -151,7 +151,7 @@

>               c = common.commit(author=self.recode(d["user"]),

>                                 date=util.datestr(date, '%Y-%m-%d %H:%M:%S %1%2'),

>                                 parents=parents, desc=desc, branch=None,

> -                              extra={"p4": change})

> +                              extra={"p4": change, "convert_revision": change})

>   

>               files = []

>               copies = {}

> _______________________________________________

> Mercurial-devel mailing list

> Mercurial-devel@mercurial-scm.org

> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
David Soria Parra - Dec. 7, 2016, 9:52 p.m.
On Wed, Dec 07, 2016 at 09:48:28PM +0000, Kostia Balytskyi wrote:
> On 12/7/16 9:30 PM, David Soria Parra wrote:
> > # HG changeset patch
> > # User David Soria Parra <davidsp@fb.com>
> > # Date 1480895549 28800
> > #      Sun Dec 04 15:52:29 2016 -0800
> > # Node ID ade3103f5cf939007ca73af5e9e5853643dc8264
> > # Parent  48bf03a8f718f870256f79cbdf10550ca92c7f25
> > [convert] Use convert_revision for P4 imports
> This does not follow our naming scheme "keyword: some short description"
woops. resent as v3

Patch

diff --git a/hgext/convert/p4.py b/hgext/convert/p4.py
--- a/hgext/convert/p4.py
+++ b/hgext/convert/p4.py
@@ -151,7 +151,7 @@ 
             c = common.commit(author=self.recode(d["user"]),
                               date=util.datestr(date, '%Y-%m-%d %H:%M:%S %1%2'),
                               parents=parents, desc=desc, branch=None,
-                              extra={"p4": change})
+                              extra={"p4": change, "convert_revision": change})
 
             files = []
             copies = {}