Patchwork [remotefilelog-ext] cdatapack: include sys/types.h for off_t

login
register
mail settings
Submitter Augie Fackler
Date Nov. 28, 2016, 10:27 p.m.
Message ID <26bc28cb6f435212bf1a.1480372025@augie-macbookair2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/17769/
State Accepted
Delegated to: Jun Wu
Headers show

Comments

Augie Fackler - Nov. 28, 2016, 10:27 p.m.
# HG changeset patch
# User Augie Fackler <augie@google.com>
# Date 1480371885 18000
#      Mon Nov 28 17:24:45 2016 -0500
# Node ID 26bc28cb6f435212bf1a3a120e21175754a7af5e
# Parent  214ac612b5f1555c52ed2c3c4f70551bce880346
cdatapack: include sys/types.h for off_t

This isn't required on all systems, but I ran into one where it
was. Sigh. I've struggled a bit to find proper documentation of this,
and this is the best I could do:
http://pubs.opengroup.org/onlinepubs/009696799/basedefs/sys/types.h.html
Jun Wu - Nov. 29, 2016, 11:28 a.m.
Pushed. Thanks!

Excerpts from Augie Fackler's message of 2016-11-28 17:27:05 -0500:
> # HG changeset patch
> # User Augie Fackler <augie@google.com>
> # Date 1480371885 18000
> #      Mon Nov 28 17:24:45 2016 -0500
> # Node ID 26bc28cb6f435212bf1a3a120e21175754a7af5e
> # Parent  214ac612b5f1555c52ed2c3c4f70551bce880346
> cdatapack: include sys/types.h for off_t
> 
> This isn't required on all systems, but I ran into one where it
> was. Sigh. I've struggled a bit to find proper documentation of this,
> and this is the best I could do:
> http://pubs.opengroup.org/onlinepubs/009696799/basedefs/sys/types.h.html 
> 
> diff --git a/cdatapack/cdatapack.h b/cdatapack/cdatapack.h
> --- a/cdatapack/cdatapack.h
> +++ b/cdatapack/cdatapack.h
> @@ -10,6 +10,7 @@
>  #include <stdint.h>
>  #include <stddef.h>
>  #include <stdbool.h>
> +#include <sys/types.h>
>  
>  #define NODE_SZ 20
>

Patch

diff --git a/cdatapack/cdatapack.h b/cdatapack/cdatapack.h
--- a/cdatapack/cdatapack.h
+++ b/cdatapack/cdatapack.h
@@ -10,6 +10,7 @@ 
 #include <stdint.h>
 #include <stddef.h>
 #include <stdbool.h>
+#include <sys/types.h>
 
 #define NODE_SZ 20