Patchwork [2,of,3] tests: do not skip code-checking on some whole files

login
register
mail settings
Submitter Simon Heimberg
Date July 1, 2013, 5:03 a.m.
Message ID <9f1b62927ce36c537840.1372654992@lapsi.heimberg.home>
Download mbox | patch
Permalink /patch/1774/
State Accepted
Commit e033a7d444ac2856948f245f463cfef39e5a48f0
Delegated to: Kevin Bullock
Headers show

Comments

Simon Heimberg - July 1, 2013, 5:03 a.m.
# HG changeset patch
# User Simon Heimberg <simohe@besonet.ch>
# Date 1372654258 -7200
# Node ID 9f1b62927ce36c53784035b7ca3996240fc81b05
# Parent  4e41528b9b05e8bdb7f2d5ded7a25e3f0833354b
tests: do not skip code-checking on some whole files

In filterpyflakes the term no-check-code was probably by accident.
In the test the intention was not to skip the entire file but only one
line. But any skipping seems to be unnecessary since a longer time.

Patch

diff -r 4e41528b9b05 -r 9f1b62927ce3 tests/filterpyflakes.py
--- a/tests/filterpyflakes.py	Mon Jul 01 06:50:58 2013 +0200
+++ b/tests/filterpyflakes.py	Mon Jul 01 06:50:58 2013 +0200
@@ -42,7 +42,7 @@ 
     f = open(os.path.join(os.path.dirname(os.path.dirname(__file__)), fn))
     data = f.read()
     f.close()
-    if 'no-check-code' in data:
+    if 'no-' 'check-code' in data:
         continue
     lines.append((msgtype, line))
 
diff -r 4e41528b9b05 -r 9f1b62927ce3 tests/test-remove.t
--- a/tests/test-remove.t	Mon Jul 01 06:50:58 2013 +0200
+++ b/tests/test-remove.t	Mon Jul 01 06:50:58 2013 +0200
@@ -1,6 +1,6 @@ 
   $ remove() {
   >     hg rm $@
-  >     echo "exit code: $?" # no-check-code
+  >     echo "exit code: $?"
   >     hg st
   >     # do not use ls -R, which recurses in .hg subdirs on Mac OS X 10.5
   >     find . -name .hg -prune -o -type f -print | sort