Patchwork censor: flag internal documentation

login
register
mail settings
Submitter Remi Chaintron
Date Nov. 23, 2016, 3:43 p.m.
Message ID <f9ec5cd22586138cdcf5.1479915807@iphonesleepsort.dhcp.thefacebook.com>
Download mbox | patch
Permalink /patch/17717/
State Superseded
Headers show

Comments

Remi Chaintron - Nov. 23, 2016, 3:43 p.m.
# HG changeset patch
# User Remi Chaintron <remi@fb.com>
# Date 1479915779 0
#      Wed Nov 23 15:42:59 2016 +0000
# Branch stable
# Node ID f9ec5cd22586138cdcf5cfebc88f1bcba41a2a20
# Parent  819f96b82fa4c4c6d07840a2b180d112b524103f
censor: flag internal documentation
Pierre-Yves David - Nov. 23, 2016, 5:08 p.m.
On 11/23/2016 04:43 PM, Remi Chaintron wrote:
> # HG changeset patch
> # User Remi Chaintron <remi@fb.com>
> # Date 1479915779 0
> #      Wed Nov 23 15:42:59 2016 +0000
> # Branch stable
> # Node ID f9ec5cd22586138cdcf5cfebc88f1bcba41a2a20
> # Parent  819f96b82fa4c4c6d07840a2b180d112b524103f
> censor: flag internal documentation
>
> diff --git a/mercurial/help/internals/revlogs.txt b/mercurial/help/internals/revlogs.txt
> --- a/mercurial/help/internals/revlogs.txt
> +++ b/mercurial/help/internals/revlogs.txt
> @@ -88,7 +88,9 @@
>  0-5 (6 bytes)
>     Absolute offset of revision data from beginning of revlog.
>  6-7 (2 bytes)
> -   Bit flags impacting revision behavior.
> +   Bit flags impacting revision behavior. The following bit offsets define:
> +   0
> +      'censor' extension flag.

The formating is a bit strange here, it seems like it is matching the 
outer layer formatting but it seems less necessary for this 1 digit 
data. Is there any formal reason we need it this way? Or could we move 
to "0: 'censor' flag"

>  8-11 (4 bytes)
>     Compressed length of revision data / chunk as stored in revlog.
>  12-15 (4 bytes)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/mercurial/help/internals/revlogs.txt b/mercurial/help/internals/revlogs.txt
--- a/mercurial/help/internals/revlogs.txt
+++ b/mercurial/help/internals/revlogs.txt
@@ -88,7 +88,9 @@ 
 0-5 (6 bytes)
    Absolute offset of revision data from beginning of revlog.
 6-7 (2 bytes)
-   Bit flags impacting revision behavior.
+   Bit flags impacting revision behavior. The following bit offsets define:
+   0
+      'censor' extension flag.
 8-11 (4 bytes)
    Compressed length of revision data / chunk as stored in revlog.
 12-15 (4 bytes)