Patchwork help: clarify contents of revlog index

login
register
mail settings
Submitter Gregory Szorc
Date Nov. 23, 2016, 2:13 a.m.
Message ID <96679cda009dfad247dc.1479867189@ubuntu-vm-main>
Download mbox | patch
Permalink /patch/17715/
State Accepted
Headers show

Comments

Gregory Szorc - Nov. 23, 2016, 2:13 a.m.
# HG changeset patch
# User Gregory Szorc <gregory.szorc@gmail.com>
# Date 1479867182 28800
#      Tue Nov 22 18:13:02 2016 -0800
# Node ID 96679cda009dfad247dc50013165d08093dc2737
# Parent  01d8600955ccbc8cd53db2c1613ec7c3f7913ee2
help: clarify contents of revlog index

The previous wording indicated that field at index 3 was the
size of the decompressed chunk, not the size of the full
revision text.
Pierre-Yves David - Nov. 23, 2016, 3:42 p.m.
On 11/23/2016 03:13 AM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc@gmail.com>
> # Date 1479867182 28800
> #      Tue Nov 22 18:13:02 2016 -0800
> # Node ID 96679cda009dfad247dc50013165d08093dc2737
> # Parent  01d8600955ccbc8cd53db2c1613ec7c3f7913ee2
> help: clarify contents of revlog index

This one is pushed, thanks.

Patch

diff --git a/mercurial/help/internals/revlogs.txt b/mercurial/help/internals/revlogs.txt
--- a/mercurial/help/internals/revlogs.txt
+++ b/mercurial/help/internals/revlogs.txt
@@ -92,7 +92,8 @@  6-7 (2 bytes)
 8-11 (4 bytes)
    Compressed length of revision data / chunk as stored in revlog.
 12-15 (4 bytes)
-   Uncompressed length of revision data / chunk.
+   Uncompressed length of revision data. This is the size of the full
+   revision data, not the size of the chunk post decompression.
 16-19 (4 bytes)
    Base or previous revision this revision's delta was produced against.
    -1 means this revision holds full text (as opposed to a delta).