Patchwork [stable] shelve: add missing space in help text

login
register
mail settings
Submitter Mads Kiilerich
Date Nov. 17, 2016, 5:53 p.m.
Message ID <649dbbabbd067aea7fe9.1479405217@madski>
Download mbox | patch
Permalink /patch/17619/
State Superseded
Headers show

Comments

Mads Kiilerich - Nov. 17, 2016, 5:53 p.m.
# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 1479159805 -3600
#      Mon Nov 14 22:43:25 2016 +0100
# Branch stable
# Node ID 649dbbabbd067aea7fe96bab700835f60a9b1ef3
# Parent  e0ff47999b1384e42bdc99f5026c7e2ed5405047
shelve: add missing space in help text
Jun Wu - Nov. 17, 2016, 6:05 p.m.
Curious: in situations like this, do i18n translators need to re-translate
the text?

Excerpts from Mads Kiilerich's message of 2016-11-17 18:53:37 +0100:
> # HG changeset patch
> # User Mads Kiilerich <madski@unity3d.com>
> # Date 1479159805 -3600
> #      Mon Nov 14 22:43:25 2016 +0100
> # Branch stable
> # Node ID 649dbbabbd067aea7fe96bab700835f60a9b1ef3
> # Parent  e0ff47999b1384e42bdc99f5026c7e2ed5405047
> shelve: add missing space in help text
> 
> diff --git a/hgext/shelve.py b/hgext/shelve.py
> --- a/hgext/shelve.py
> +++ b/hgext/shelve.py
> @@ -865,7 +865,7 @@ def shelvecmd(ui, repo, *pats, **opts):
>      files. If specific files or directories are named, only changes to
>      those files are shelved.
>  
> -    In bare shelve(when no files are specified, without interactive,
> +    In bare shelve (when no files are specified, without interactive,
>      include and exclude option), shelving remembers information if the
>      working directory was on newly created branch, in other words working
>      directory was on different branch than its first parent. In this
Mads Kiilerich - Nov. 17, 2016, 6:32 p.m.
On 11/17/2016 07:05 PM, Jun Wu wrote:
> Curious: in situations like this, do i18n translators need to re-translate
> the text?

Yeah, the sentence has been translated to Japanese and Portuguese, but 
the missing space has probably already been "lost in translation". There 
should thus not be any need for re-translation in this case.

Also, I did apparently not run tests and missed tests/test-shelve.t . I 
will resend. So much ado for so little - how hard can it be ;-)

/Mads

Patch

diff --git a/hgext/shelve.py b/hgext/shelve.py
--- a/hgext/shelve.py
+++ b/hgext/shelve.py
@@ -865,7 +865,7 @@  def shelvecmd(ui, repo, *pats, **opts):
     files. If specific files or directories are named, only changes to
     those files are shelved.
 
-    In bare shelve(when no files are specified, without interactive,
+    In bare shelve (when no files are specified, without interactive,
     include and exclude option), shelving remembers information if the
     working directory was on newly created branch, in other words working
     directory was on different branch than its first parent. In this