Patchwork [v2] build: include a dummy $PATH in the custom environment used by build.py

login
register
mail settings
Submitter Gábor Stefanik
Date Nov. 14, 2016, 3:04 p.m.
Message ID <1f4674a0ddddaaeae579.1479135886@GSTEFANIK.NavnGo.local>
Download mbox | patch
Permalink /patch/17562/
State Accepted
Headers show

Comments

Gábor Stefanik - Nov. 14, 2016, 3:04 p.m.
# HG changeset patch
# User Gábor Stefanik <gabor.stefanik@nng.com>
# Date 1477669468 -7200
#      Fri Oct 28 17:44:28 2016 +0200
# Node ID 1f4674a0ddddaaeae579186ae6e5c3a022c25ab5
# Parent  046a7e828ea63ec940ffae1089a33fae7954da2e
build: include a dummy $PATH in the custom environment used by build.py

This is required for building with pypiwin32, the pip-installable replacement
for pywin32.
Yuya Nishihara - Nov. 19, 2016, 9:48 a.m.
On Mon, 14 Nov 2016 16:04:46 +0100, Gábor Stefanik wrote:
> # HG changeset patch
> # User Gábor Stefanik <gabor.stefanik@nng.com>
> # Date 1477669468 -7200
> #      Fri Oct 28 17:44:28 2016 +0200
> # Node ID 1f4674a0ddddaaeae579186ae6e5c3a022c25ab5
> # Parent  046a7e828ea63ec940ffae1089a33fae7954da2e
> build: include a dummy $PATH in the custom environment used by build.py
> 
> This is required for building with pypiwin32, the pip-installable replacement
> for pywin32.
> 
> diff -r 046a7e828ea6 -r 1f4674a0dddd setup.py
> --- a/setup.py	Thu Nov 10 16:37:18 2016 -0500
> +++ b/setup.py	Fri Oct 28 17:44:28 2016 +0200
> @@ -167,7 +167,8 @@
>  # to not use any hgrc files and do no localization.
>  env = {'HGMODULEPOLICY': 'py',
>         'HGRCPATH': '',
> -       'LANGUAGE': 'C'}
> +       'LANGUAGE': 'C',
> +       'PATH': ''} # make pypi modules that use os.environ['PATH'] happy

Looks okay. Queued, thanks.

Patch

diff -r 046a7e828ea6 -r 1f4674a0dddd setup.py
--- a/setup.py	Thu Nov 10 16:37:18 2016 -0500
+++ b/setup.py	Fri Oct 28 17:44:28 2016 +0200
@@ -167,7 +167,8 @@ 
 # to not use any hgrc files and do no localization.
 env = {'HGMODULEPOLICY': 'py',
        'HGRCPATH': '',
-       'LANGUAGE': 'C'}
+       'LANGUAGE': 'C',
+       'PATH': ''} # make pypi modules that use os.environ['PATH'] happy
 if 'LD_LIBRARY_PATH' in os.environ:
     env['LD_LIBRARY_PATH'] = os.environ['LD_LIBRARY_PATH']
 if 'SystemRoot' in os.environ: