Patchwork [python-hglib] add init() to hgclient to allow progress to be reported

login
register
mail settings
Submitter Barry A. Scott
Date Oct. 28, 2016, 10:47 a.m.
Message ID <ab7eec553872e3e5bc58.1477651629@varric.chelsea.private>
Download mbox | patch
Permalink /patch/17210/
State Accepted
Headers show

Comments

Barry A. Scott - Oct. 28, 2016, 10:47 a.m.
# HG changeset patch
# User Barry A. Scott <barry@barrys-emacs.org>
# Date 1477651557 -3600
#      Fri Oct 28 11:45:57 2016 +0100
# Node ID ab7eec553872e3e5bc58c73b09a61f73f6470690
# Parent  6f15cb7cc9cb4427f35c60080f85dbf4ca5abd10
add init() to hgclient to allow progress to be reported

The init() command is required as a member of hgclient
so that progress, output and errors from the init() command
can be sent to cbout and cberr call backs.
Yuya Nishihara - Oct. 28, 2016, 1:24 p.m.
On Fri, 28 Oct 2016 11:47:09 +0100, Barry A. Scott wrote:
> # HG changeset patch
> # User Barry A. Scott <barry@barrys-emacs.org>
> # Date 1477651557 -3600
> #      Fri Oct 28 11:45:57 2016 +0100
> # Node ID ab7eec553872e3e5bc58c73b09a61f73f6470690
> # Parent  6f15cb7cc9cb4427f35c60080f85dbf4ca5abd10
> add init() to hgclient to allow progress to be reported
> 
> The init() command is required as a member of hgclient
> so that progress, output and errors from the init() command
> can be sent to cbout and cberr call backs.

Looks good to me. Marked as pre-reviewd, thanks.

Also, can you add some tests as a follow-up?
Barry A. Scott - Oct. 28, 2016, 7:11 p.m.
> On 28 Oct 2016, at 14:24, Yuya Nishihara <yuya@tcha.org> wrote:
> 
> On Fri, 28 Oct 2016 11:47:09 +0100, Barry A. Scott wrote:
>> # HG changeset patch
>> # User Barry A. Scott <barry@barrys-emacs.org>
>> # Date 1477651557 -3600
>> #      Fri Oct 28 11:45:57 2016 +0100
>> # Node ID ab7eec553872e3e5bc58c73b09a61f73f6470690
>> # Parent  6f15cb7cc9cb4427f35c60080f85dbf4ca5abd10
>> add init() to hgclient to allow progress to be reported
>> 
>> The init() command is required as a member of hgclient
>> so that progress, output and errors from the init() command
>> can be sent to cbout and cberr call backs.
> 
> Looks good to me. Marked as pre-reviewd, thanks

What is process now that the patches are pre-review?

> 
> Also, can you add some tests as a follow-up?

I will look into how the test work and see what I can do.

Barry
Yuya Nishihara - Oct. 29, 2016, 2:39 a.m.
On Fri, 28 Oct 2016 20:11:03 +0100, Barry Scott wrote:
> > On 28 Oct 2016, at 14:24, Yuya Nishihara <yuya@tcha.org> wrote:
> > On Fri, 28 Oct 2016 11:47:09 +0100, Barry A. Scott wrote:
> >> # HG changeset patch
> >> # User Barry A. Scott <barry@barrys-emacs.org>
> >> # Date 1477651557 -3600
> >> #      Fri Oct 28 11:45:57 2016 +0100
> >> # Node ID ab7eec553872e3e5bc58c73b09a61f73f6470690
> >> # Parent  6f15cb7cc9cb4427f35c60080f85dbf4ca5abd10
> >> add init() to hgclient to allow progress to be reported
> >> 
> >> The init() command is required as a member of hgclient
> >> so that progress, output and errors from the init() command
> >> can be sent to cbout and cberr call backs.
> > 
> > Looks good to me. Marked as pre-reviewd, thanks
> 
> What is process now that the patches are pre-review?

Marked as reviewed by non-committer. I don't have push access to the
python-hglib repository.

https://patchwork.mercurial-scm.org/project/hg/list/
https://www.mercurial-scm.org/wiki/ReviewProcess#Patchwork_States

> > Also, can you add some tests as a follow-up?
> 
> I will look into how the test work and see what I can do.

Thanks.

Patch

diff -r 6f15cb7cc9cb -r ab7eec553872 hglib/client.py
--- a/hglib/client.py	Mon Jul 18 23:40:45 2016 -0500
+++ b/hglib/client.py	Fri Oct 28 11:45:57 2016 +0100
@@ -539,6 +539,11 @@ 
                           u=updaterev, r=revrange)
         self.rawcommand(args)
 
+    def init(self, dest, ssh=None, remotecmd=None, insecure=False):
+        args = util.cmdbuilder('init', dest, e=ssh, remotecmd=remotecmd,
+                               insecure=insecure)
+        self.rawcommand(args)
+
     def commit(self, message=None, logfile=None, addremove=False,
                closebranch=False, date=None, user=None, include=None,
                exclude=None, amend=False):