Patchwork run-tests: call Threads constructor with keyword arguments

login
register
mail settings
Submitter Simon Heimberg
Date June 10, 2013, 4:51 p.m.
Message ID <967b89a1b89a76cde289.1370883098@lapsi.heimberg.home>
Download mbox | patch
Permalink /patch/1716/
State Accepted
Commit aedb4d0012ffc4dbd9a30af857ee7cbd6dd2719a
Headers show

Comments

Simon Heimberg - June 10, 2013, 4:51 p.m.
# HG changeset patch
# User simon@laptop-tosh
# Date 1370789348 -7200
# Node ID 967b89a1b89a76cde289c8d71c2da807751ef2ab
# Parent  a3645a98eda5ab9cfe5eba4a3ccda6745d5f3fef
run-tests: call Threads constructor with keyword arguments

This is suggested in the python documentation
(on http://docs.python.org/2/library/threading.html#thread-objects)
Matt Mackall - June 12, 2013, 9:05 p.m.
On Mon, 2013-06-10 at 18:51 +0200, Simon Heimberg wrote:
> # HG changeset patch
> # User simon@laptop-tosh
> # Date 1370789348 -7200
> # Node ID 967b89a1b89a76cde289c8d71c2da807751ef2ab
> # Parent  a3645a98eda5ab9cfe5eba4a3ccda6745d5f3fef
> run-tests: call Threads constructor with keyword arguments

Queued for default, thanks.

Patch

diff -r a3645a98eda5 -r 967b89a1b89a tests/run-tests.py
--- a/tests/run-tests.py	Son Jun 09 16:42:55 2013 +0200
+++ b/tests/run-tests.py	Son Jun 09 16:49:08 2013 +0200
@@ -1092,7 +1092,7 @@ 
                 test = tests.pop(0)
                 if options.loop:
                     tests.append(test)
-                t = threading.Thread(None, job, args=(test, count))
+                t = threading.Thread(target=job, args=(test, count))
                 t.start()
                 running += 1
                 count += 1