From patchwork Sat Jun 8 18:57:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [2,of,5] check-code: compile all patterns on initialisation From: Simon Heimberg X-Patchwork-Id: 1710 Message-Id: To: Mercurial-devel Date: Sat, 08 Jun 2013 20:57:00 +0200 # HG changeset patch # User Simon Heimberg # Date 1370715614 -7200 # Node ID ddedc8623eb8287b7d5bc50a6c24404a6ec39c8a # Parent e32bdfb08c8ff96f9f50bfb60888c187830e3ac6 check-code: compile all patterns on initialisation They where compiled once for every checked file (when calling finditer). diff -r e32bdfb08c8f -r ddedc8623eb8 contrib/check-code.py --- a/contrib/check-code.py Sam Jun 08 20:20:14 2013 +0200 +++ b/contrib/check-code.py Sam Jun 08 20:20:14 2013 +0200 @@ -330,7 +330,7 @@ p = re.sub(r'(?', p - pats[i] = (p,) + pseq[1:] + pats[i] = (re.compile(p, re.MULTILINE),) + pseq[1:] _preparepats() class norepeatlogger(object): @@ -421,7 +421,7 @@ pos = 0 n = 0 - for m in re.finditer(p, post, re.MULTILINE): + for m in p.finditer(post): if prelines is None: prelines = pre.splitlines() postlines = post.splitlines(True)