Patchwork [3,of,9,V6] bookmarks: introduce BookmarksDecodeError

login
register
mail settings
Submitter Stanislau Hlebik
Date Oct. 11, 2016, 4:25 p.m.
Message ID <6f5a3300a5457c92eb09.1476203145@dev1918.lla1.facebook.com>
Download mbox | patch
Permalink /patch/17030/
State Changes Requested
Headers show

Comments

Stanislau Hlebik - Oct. 11, 2016, 4:25 p.m.
# HG changeset patch
# User Stanislau Hlebik <stash@fb.com>
# Date 1476195835 25200
#      Tue Oct 11 07:23:55 2016 -0700
# Node ID 6f5a3300a5457c92eb09170a30c98328ebe3bcce
# Parent  91ae660eb2faf74cb96ee7ee5bdcc1f2507f9cf7
bookmarks: introduce BookmarksDecodeError

Binary encoding for bookmarks will be added in next diffs.
This error will be thrown if there are problems with bookmarks decoding.
Pierre-Yves David - Oct. 13, 2016, 4:17 p.m.
On 10/11/2016 06:25 PM, Stanislau Hlebik wrote:
> # HG changeset patch
> # User Stanislau Hlebik <stash@fb.com>
> # Date 1476195835 25200
> #      Tue Oct 11 07:23:55 2016 -0700
> # Node ID 6f5a3300a5457c92eb09170a30c98328ebe3bcce
> # Parent  91ae660eb2faf74cb96ee7ee5bdcc1f2507f9cf7
> bookmarks: introduce BookmarksDecodeError
>
> Binary encoding for bookmarks will be added in next diffs.
> This error will be thrown if there are problems with bookmarks decoding.

Same feedback as for BookmarksEncodeError, it seems lik we could just go 
with ValueError unless I'm missing something.

Cheers,

Patch

diff --git a/mercurial/error.py b/mercurial/error.py
--- a/mercurial/error.py
+++ b/mercurial/error.py
@@ -247,3 +247,7 @@ 
 class BookmarksEncodeError(Exception):
     """Raised if bookmarks can't be encoded
     """
+
+class BookmarksDecodeError(Exception):
+    """Raised if bookmarks can't be decoded
+    """