Patchwork [4,of,4,V3] hgweb: change inserted line color in file comparison view

login
register
mail settings
Submitter Alexander Plavin
Date June 1, 2013, 6:09 p.m.
Message ID <80d84be65b09e8650651.1370110194@debian-alexander.dolgopa>
Download mbox | patch
Permalink /patch/1695/
State Changes Requested, archived
Headers show

Comments

Alexander Plavin - June 1, 2013, 6:09 p.m.
# HG changeset patch
# User Alexander Plavin <me@aplavin.ru>
# Date 1369991879 -14400
#      Fri May 31 13:17:59 2013 +0400
# Node ID 80d84be65b09e8650651eb5e366169458a133246
# Parent  c6bbbc51246371efc23644a4dbbf75df14dc384b
hgweb: change inserted line color in file comparison view

Change the color from yellow to green, not to interfere with
linked line highlight and for consistency.
Matt Mackall - June 1, 2013, 9:18 p.m.
On Sat, 2013-06-01 at 22:09 +0400, Alexander Plavin wrote:
> # HG changeset patch
> # User Alexander Plavin <me@aplavin.ru>
> # Date 1369991879 -14400
> #      Fri May 31 13:17:59 2013 +0400
> # Node ID 80d84be65b09e8650651eb5e366169458a133246
> # Parent  c6bbbc51246371efc23644a4dbbf75df14dc384b
> hgweb: change inserted line color in file comparison view
> 
> Change the color from yellow to green, not to interfere with
> linked line highlight and for consistency.

The diff colors were carefully chosen to be distinct for people with
with multiple forms of colorblindness. You can't touch them without
doing another survey, and you definitely can't use red and green.

Patch

diff -r c6bbbc512463 -r 80d84be65b09 mercurial/templates/static/style-paper.css
--- a/mercurial/templates/static/style-paper.css	Fri May 31 13:05:28 2013 +0400
+++ b/mercurial/templates/static/style-paper.css	Fri May 31 13:17:59 2013 +0400
@@ -337,7 +337,7 @@ 
 }
 
 .insert {
-    background-color: #ffa;
+    background-color: #afa;
 }
 
 .replace {