Patchwork check-commit: allow underscore as commit topic

login
register
mail settings
Submitter Mathias De Maré
Date Oct. 5, 2016, 2:02 p.m.
Message ID <88b22f2c1aee03d452e8.1475676147@waste.org>
Download mbox | patch
Permalink /patch/16865/
State Accepted
Headers show

Comments

Mathias De Maré - Oct. 5, 2016, 2:02 p.m.
# HG changeset patch
# User Mathias De Maré <mathias.de_mare@nokia.com>
# Date 1475674114 -7200
#      Wed Oct 05 15:28:34 2016 +0200
# Node ID 88b22f2c1aee03d452e8b125442c69cd8bb62703
# Parent  1779dde4c9ef97cb242f8d501655f236f66e5439
check-commit: allow underscore as commit topic

It's currently not possible to commit with a changeset topic
like 'bash_completion'. This change fixes that.
Pierre-Yves David - Oct. 8, 2016, 9:23 a.m.
On 10/05/2016 04:02 PM, Mathias De Maré wrote:
> # HG changeset patch
> # User Mathias De Maré <mathias.de_mare@nokia.com>
> # Date 1475674114 -7200
> #      Wed Oct 05 15:28:34 2016 +0200
> # Node ID 88b22f2c1aee03d452e8b125442c69cd8bb62703
> # Parent  1779dde4c9ef97cb242f8d501655f236f66e5439
> check-commit: allow underscore as commit topic
>
> It's currently not possible to commit with a changeset topic
> like 'bash_completion'. This change fixes that.

Pushed, thanks,

cheers.

Patch

diff --git a/contrib/check-commit b/contrib/check-commit
--- a/contrib/check-commit
+++ b/contrib/check-commit
@@ -35,7 +35,7 @@ 
      "summary line doesn't start with 'topic: '"),
     (afterheader + r"[A-Z][a-z]\S+", "don't capitalize summary lines"),
     (afterheader + r"[^\n]*: *[A-Z][a-z]\S+", "don't capitalize summary lines"),
-    (afterheader + r"\S*[^A-Za-z0-9-]\S*: ",
+    (afterheader + r"\S*[^A-Za-z0-9-_]\S*: ",
      "summary keyword should be most user-relevant one-word command or topic"),
     (afterheader + r".*\.\s*\n", "don't add trailing period on summary line"),
     (afterheader + r".{79,}", "summary line too long (limit is 78)"),