Patchwork hgweb: make anchor name actually match its href on help index page

login
register
mail settings
Submitter Anton Shestakov
Date Sept. 26, 2016, 12:34 p.m.
Message ID <1297ca16b8529d4fbd2f.1474893253@neuro>
Download mbox | patch
Permalink /patch/16788/
State Accepted
Headers show

Comments

Anton Shestakov - Sept. 26, 2016, 12:34 p.m.
# HG changeset patch
# User Anton Shestakov <av6@dwimlabs.net>
# Date 1474877560 -28800
#      Mon Sep 26 16:12:40 2016 +0800
# Node ID 1297ca16b8529d4fbd2f4a8e7827d48e13ee5e4d
# Parent  e83f89d3b1f733d0ee5f23f6a2293279a17fbbfb
hgweb: make anchor name actually match its href on help index page
Pierre-Yves David - Sept. 27, 2016, 3:09 p.m.
On 09/26/2016 02:34 PM, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov <av6@dwimlabs.net>
> # Date 1474877560 -28800
> #      Mon Sep 26 16:12:40 2016 +0800
> # Node ID 1297ca16b8529d4fbd2f4a8e7827d48e13ee5e4d
> # Parent  e83f89d3b1f733d0ee5f23f6a2293279a17fbbfb
> hgweb: make anchor name actually match its href on help index page

Pushed thanks.

Patch

diff --git a/mercurial/templates/gitweb/helptopics.tmpl b/mercurial/templates/gitweb/helptopics.tmpl
--- a/mercurial/templates/gitweb/helptopics.tmpl
+++ b/mercurial/templates/gitweb/helptopics.tmpl
@@ -30,7 +30,7 @@ 
 
 <div class="title">&nbsp;</div>
 <table cellspacing="0">
-<tr><td colspan="2"><h2><a name="main" href="#topics">Topics</a></h2></td></tr>
+<tr><td colspan="2"><h2><a name="topics" href="#topics">Topics</a></h2></td></tr>
 {topics % helpentry}
 
 {if(earlycommands, '
diff --git a/mercurial/templates/monoblue/helptopics.tmpl b/mercurial/templates/monoblue/helptopics.tmpl
--- a/mercurial/templates/monoblue/helptopics.tmpl
+++ b/mercurial/templates/monoblue/helptopics.tmpl
@@ -35,7 +35,7 @@ 
 
     <h2 class="no-link no-border">help</h2>
     <table cellspacing="0">
-    <tr><td colspan="2"><h2><a name="main" href="#topics">Topics</a></h2></td></tr>
+    <tr><td colspan="2"><h2><a name="topics" href="#topics">Topics</a></h2></td></tr>
     {topics % helpentry}
 
     {if(earlycommands, '
diff --git a/mercurial/templates/paper/helptopics.tmpl b/mercurial/templates/paper/helptopics.tmpl
--- a/mercurial/templates/paper/helptopics.tmpl
+++ b/mercurial/templates/paper/helptopics.tmpl
@@ -32,7 +32,7 @@ 
 <div id="hint">{searchhint}</div>
 </form>
 <table class="bigtable">
-<tr><td colspan="2"><h2><a name="main" href="#topics">Topics</a></h2></td></tr>
+<tr><td colspan="2"><h2><a name="topics" href="#topics">Topics</a></h2></td></tr>
 {topics % helpentry}
 
 {if(earlycommands, '
diff --git a/tests/test-help.t b/tests/test-help.t
--- a/tests/test-help.t
+++ b/tests/test-help.t
@@ -1828,7 +1828,7 @@  Dish up an empty repo; serve it cold.
   number or hash, or <a href="/help/revsets">revset expression</a>.</div>
   </form>
   <table class="bigtable">
-  <tr><td colspan="2"><h2><a name="main" href="#topics">Topics</a></h2></td></tr>
+  <tr><td colspan="2"><h2><a name="topics" href="#topics">Topics</a></h2></td></tr>
   
   <tr><td>
   <a href="/help/config">
@@ -2880,7 +2880,7 @@  Sub-topic indexes rendered properly
   number or hash, or <a href="/help/revsets">revset expression</a>.</div>
   </form>
   <table class="bigtable">
-  <tr><td colspan="2"><h2><a name="main" href="#topics">Topics</a></h2></td></tr>
+  <tr><td colspan="2"><h2><a name="topics" href="#topics">Topics</a></h2></td></tr>
   
   <tr><td>
   <a href="/help/internals.bundles">