Patchwork [17,of,17] tests: favor single quotes for wrapping hg help

login
register
mail settings
Submitter timeless
Date Sept. 21, 2016, 12:19 a.m.
Message ID <07306ec6e0c4e0accdaf.1474417198@gcc2-power8.osuosl.org>
Download mbox | patch
Permalink /patch/16722/
State Accepted
Headers show

Comments

timeless - Sept. 21, 2016, 12:19 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1474415360 0
#      Tue Sep 20 23:49:20 2016 +0000
# Node ID 07306ec6e0c4e0accdaf3efee348361f36910295
# Parent  0f8eca5689fad5be2cef54141c8185b8bd5639f3
# Available At https://bitbucket.org/timeless/mercurial-crew
#              hg pull https://bitbucket.org/timeless/mercurial-crew -r 07306ec6e0c4
tests: favor single quotes for wrapping hg help ...
Pierre-Yves David - Sept. 21, 2016, 11:29 a.m.
On 09/21/2016 02:19 AM, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1474415360 0
> #      Tue Sep 20 23:49:20 2016 +0000
> # Node ID 07306ec6e0c4e0accdaf3efee348361f36910295
> # Parent  0f8eca5689fad5be2cef54141c8185b8bd5639f3
> # Available At https://bitbucket.org/timeless/mercurial-crew
> #              hg pull https://bitbucket.org/timeless/mercurial-crew -r 07306ec6e0c4
> tests: favor single quotes for wrapping hg help ...

Pushed this, Thanks for the extensive clean up.

Cheers,
via Mercurial-devel - Sept. 21, 2016, 1:34 p.m.
I have a version of this series locally with some cleanups that I talked to
timeless about on IRC. I feel asleep before tests had finished running, but
I'll do your version of it and replace it by mine when I get to work in a
few hours. Sorry, should have at least remembered to update this thread
yesterday.

On Wed, Sep 21, 2016, 04:29 Pierre-Yves David <
pierre-yves.david@ens-lyon.org> wrote:

> On 09/21/2016 02:19 AM, timeless wrote:
> > # HG changeset patch
> > # User timeless <timeless@mozdev.org>
> > # Date 1474415360 0
> > #      Tue Sep 20 23:49:20 2016 +0000
> > # Node ID 07306ec6e0c4e0accdaf3efee348361f36910295
> > # Parent  0f8eca5689fad5be2cef54141c8185b8bd5639f3
> > # Available At https://bitbucket.org/timeless/mercurial-crew
> > #              hg pull https://bitbucket.org/timeless/mercurial-crew -r
> 07306ec6e0c4
> > tests: favor single quotes for wrapping hg help ...
>
> Pushed this, Thanks for the extensive clean up.
>
> Cheers,
>
> --
> Pierre-Yves David
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
via Mercurial-devel - Sept. 21, 2016, 4:36 p.m.
I've pushed the cleaned-up series. What I fixed:

* Made concatenated string literals spanning multiple lines is
consistent quoting across lines
* Changed quotes around "hg -v" to single quotes where it was on the
same line as an already changed quote

On Wed, Sep 21, 2016 at 6:34 AM, Martin von Zweigbergk
<martinvonz@google.com> wrote:
> I have a version of this series locally with some cleanups that I talked to
> timeless about on IRC. I feel asleep before tests had finished running, but
> I'll do your version of it and replace it by mine when I get to work in a
> few hours. Sorry, should have at least remembered to update this thread
> yesterday.
>
>
> On Wed, Sep 21, 2016, 04:29 Pierre-Yves David
> <pierre-yves.david@ens-lyon.org> wrote:
>>
>> On 09/21/2016 02:19 AM, timeless wrote:
>> > # HG changeset patch
>> > # User timeless <timeless@mozdev.org>
>> > # Date 1474415360 0
>> > #      Tue Sep 20 23:49:20 2016 +0000
>> > # Node ID 07306ec6e0c4e0accdaf3efee348361f36910295
>> > # Parent  0f8eca5689fad5be2cef54141c8185b8bd5639f3
>> > # Available At https://bitbucket.org/timeless/mercurial-crew
>> > #              hg pull https://bitbucket.org/timeless/mercurial-crew -r
>> > 07306ec6e0c4
>> > tests: favor single quotes for wrapping hg help ...
>>
>> Pushed this, Thanks for the extensive clean up.
>>
>> Cheers,
>>
>> --
>> Pierre-Yves David
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel@mercurial-scm.org
>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff -r 0f8eca5689fa -r 07306ec6e0c4 tests/test-help.t
--- a/tests/test-help.t	Tue Sep 20 23:49:00 2016 +0000
+++ b/tests/test-help.t	Tue Sep 20 23:49:20 2016 +0000
@@ -1250,12 +1250,12 @@ 
 
   $ hg help config.`hg help config|grep '^    "'| \
   >       tail -1|sed 's![ "]*!!g'`| \
-  >   grep "hg help -c config" > /dev/null
+  >   grep 'hg help -c config' > /dev/null
   [1]
 
 note to use help -c for general hg help config:
 
-  $ hg help config |grep "hg help -c config" > /dev/null
+  $ hg help config |grep 'hg help -c config' > /dev/null
 
 Test templating help
 
@@ -1589,7 +1589,7 @@ 
   > subsequent section
   > ------------------
   > 
-  > This should be hidden at "hg help ambiguous" with section name.
+  > This should be hidden at 'hg help ambiguous' with section name.
   > '''
   > """ % (escape(upper), escape(lower)))
   > EOF
diff -r 0f8eca5689fa -r 07306ec6e0c4 tests/test-obsolete-checkheads.t
--- a/tests/test-obsolete-checkheads.t	Tue Sep 20 23:49:00 2016 +0000
+++ b/tests/test-obsolete-checkheads.t	Tue Sep 20 23:49:20 2016 +0000
@@ -122,7 +122,7 @@ 
 #   pushing to $TESTTMP/remote
 #   searching for changes
 #   abort: push creates new remote head 71e3228bffe1!
-#   (merge or see "hg help push" for details about pushing new heads)
+#   (merge or see 'hg help push' for details about pushing new heads)
 #   [255]
 
 old head is obsolete but replacement is not pushed