Patchwork [03,of,17] push: update help hint to point to config.paths section

login
register
mail settings
Submitter timeless
Date Sept. 21, 2016, 12:19 a.m.
Message ID <ca073d2379d406e61045.1474417184@gcc2-power8.osuosl.org>
Download mbox | patch
Permalink /patch/16707/
State Accepted
Headers show

Comments

timeless - Sept. 21, 2016, 12:19 a.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1474402358 0
#      Tue Sep 20 20:12:38 2016 +0000
# Node ID ca073d2379d406e610450b957a955bf05ebf64f3
# Parent  00192f6bab14f19bfd58738b732ea1a2d24317ea
# Available At https://bitbucket.org/timeless/mercurial-crew
#              hg pull https://bitbucket.org/timeless/mercurial-crew -r ca073d2379d4
push: update help hint to point to config.paths section
via Mercurial-devel - Sept. 21, 2016, 1:13 a.m.
Yuya reminded me earlier today that double quotes are better for Windows
(single quotes are not supported). So this seems like a regression in that
regard, no?

On Tue, Sep 20, 2016, 17:19 timeless <timeless@fmr.im> wrote:

> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1474402358 0
> #      Tue Sep 20 20:12:38 2016 +0000
> # Node ID ca073d2379d406e610450b957a955bf05ebf64f3
> # Parent  00192f6bab14f19bfd58738b732ea1a2d24317ea
> # Available At https://bitbucket.org/timeless/mercurial-crew
> #              hg pull https://bitbucket.org/timeless/mercurial-crew -r
> ca073d2379d4
> push: update help hint to point to config.paths section
>
> diff -r 00192f6bab14 -r ca073d2379d4 mercurial/commands.py
> --- a/mercurial/commands.py     Fri Sep 02 21:49:33 2016 +0000
> +++ b/mercurial/commands.py     Tue Sep 20 20:12:38 2016 +0000
> @@ -6020,7 +6020,7 @@
>      path = ui.paths.getpath(dest, default=('default-push', 'default'))
>      if not path:
>          raise error.Abort(_('default repository not configured!'),
> -                         hint=_('see the "path" section in "hg help
> config"'))
> +                         hint=_("see 'hg help config.paths'"))
>      dest = path.pushloc or path.loc
>      branches = (path.branch, opts.get('branch') or [])
>      ui.status(_('pushing to %s\n') % util.hidepassword(dest))
> diff -r 00192f6bab14 -r ca073d2379d4 tests/test-default-push.t
> --- a/tests/test-default-push.t Fri Sep 02 21:49:33 2016 +0000
> +++ b/tests/test-default-push.t Tue Sep 20 20:12:38 2016 +0000
> @@ -19,7 +19,7 @@
>    $ cd c
>    $ hg push --config paths.default=
>    abort: default repository not configured!
> -  (see the "path" section in "hg help config")
> +  (see 'hg help config.paths')
>    [255]
>
>    $ cd ..
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
timeless - Sept. 21, 2016, 4:02 a.m.
These aren't quotes we want users to type. Which is why we want to switch
to them.

On Sep 20, 2016 9:13 PM, "Martin von Zweigbergk" <martinvonz@google.com>
wrote:

> Yuya reminded me earlier today that double quotes are better for Windows
> (single quotes are not supported). So this seems like a regression in that
> regard, no?
>
> On Tue, Sep 20, 2016, 17:19 timeless <timeless@fmr.im> wrote:
>
>> # HG changeset patch
>> # User timeless <timeless@mozdev.org>
>> # Date 1474402358 0
>> #      Tue Sep 20 20:12:38 2016 +0000
>> # Node ID ca073d2379d406e610450b957a955bf05ebf64f3
>> # Parent  00192f6bab14f19bfd58738b732ea1a2d24317ea
>> # Available At https://bitbucket.org/timeless/mercurial-crew
>> #              hg pull https://bitbucket.org/timeless/mercurial-crew -r
>> ca073d2379d4
>> push: update help hint to point to config.paths section
>>
>> diff -r 00192f6bab14 -r ca073d2379d4 mercurial/commands.py
>> --- a/mercurial/commands.py     Fri Sep 02 21:49:33 2016 +0000
>> +++ b/mercurial/commands.py     Tue Sep 20 20:12:38 2016 +0000
>> @@ -6020,7 +6020,7 @@
>>      path = ui.paths.getpath(dest, default=('default-push', 'default'))
>>      if not path:
>>          raise error.Abort(_('default repository not configured!'),
>> -                         hint=_('see the "path" section in "hg help
>> config"'))
>> +                         hint=_("see 'hg help config.paths'"))
>>      dest = path.pushloc or path.loc
>>      branches = (path.branch, opts.get('branch') or [])
>>      ui.status(_('pushing to %s\n') % util.hidepassword(dest))
>> diff -r 00192f6bab14 -r ca073d2379d4 tests/test-default-push.t
>> --- a/tests/test-default-push.t Fri Sep 02 21:49:33 2016 +0000
>> +++ b/tests/test-default-push.t Tue Sep 20 20:12:38 2016 +0000
>> @@ -19,7 +19,7 @@
>>    $ cd c
>>    $ hg push --config paths.default=
>>    abort: default repository not configured!
>> -  (see the "path" section in "hg help config")
>> +  (see 'hg help config.paths')
>>    [255]
>>
>>    $ cd ..
>> _______________________________________________
>> Mercurial-devel mailing list
>> Mercurial-devel@mercurial-scm.org
>> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>>
>
via Mercurial-devel - Sept. 21, 2016, 4:06 a.m.
Heh, makes sense. Silly me...

On Tue, Sep 20, 2016 at 9:02 PM timeless <timeless@gmail.com> wrote:

> These aren't quotes we want users to type. Which is why we want to switch
> to them.
>
> On Sep 20, 2016 9:13 PM, "Martin von Zweigbergk" <martinvonz@google.com>
> wrote:
>
> Yuya reminded me earlier today that double quotes are better for Windows
> (single quotes are not supported). So this seems like a regression in that
> regard, no?
>
> On Tue, Sep 20, 2016, 17:19 timeless <timeless@fmr.im> wrote:
>
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1474402358 0
> #      Tue Sep 20 20:12:38 2016 +0000
> # Node ID ca073d2379d406e610450b957a955bf05ebf64f3
> # Parent  00192f6bab14f19bfd58738b732ea1a2d24317ea
> # Available At https://bitbucket.org/timeless/mercurial-crew
> #              hg pull https://bitbucket.org/timeless/mercurial-crew -r
> ca073d2379d4
> push: update help hint to point to config.paths section
>
> diff -r 00192f6bab14 -r ca073d2379d4 mercurial/commands.py
> --- a/mercurial/commands.py     Fri Sep 02 21:49:33 2016 +0000
> +++ b/mercurial/commands.py     Tue Sep 20 20:12:38 2016 +0000
> @@ -6020,7 +6020,7 @@
>      path = ui.paths.getpath(dest, default=('default-push', 'default'))
>      if not path:
>          raise error.Abort(_('default repository not configured!'),
> -                         hint=_('see the "path" section in "hg help
> config"'))
> +                         hint=_("see 'hg help config.paths'"))
>      dest = path.pushloc or path.loc
>      branches = (path.branch, opts.get('branch') or [])
>      ui.status(_('pushing to %s\n') % util.hidepassword(dest))
> diff -r 00192f6bab14 -r ca073d2379d4 tests/test-default-push.t
> --- a/tests/test-default-push.t Fri Sep 02 21:49:33 2016 +0000
> +++ b/tests/test-default-push.t Tue Sep 20 20:12:38 2016 +0000
> @@ -19,7 +19,7 @@
>    $ cd c
>    $ hg push --config paths.default=
>    abort: default repository not configured!
> -  (see the "path" section in "hg help config")
> +  (see 'hg help config.paths')
>    [255]
>
>    $ cd ..
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
>

Patch

diff -r 00192f6bab14 -r ca073d2379d4 mercurial/commands.py
--- a/mercurial/commands.py	Fri Sep 02 21:49:33 2016 +0000
+++ b/mercurial/commands.py	Tue Sep 20 20:12:38 2016 +0000
@@ -6020,7 +6020,7 @@ 
     path = ui.paths.getpath(dest, default=('default-push', 'default'))
     if not path:
         raise error.Abort(_('default repository not configured!'),
-                         hint=_('see the "path" section in "hg help config"'))
+                         hint=_("see 'hg help config.paths'"))
     dest = path.pushloc or path.loc
     branches = (path.branch, opts.get('branch') or [])
     ui.status(_('pushing to %s\n') % util.hidepassword(dest))
diff -r 00192f6bab14 -r ca073d2379d4 tests/test-default-push.t
--- a/tests/test-default-push.t	Fri Sep 02 21:49:33 2016 +0000
+++ b/tests/test-default-push.t	Tue Sep 20 20:12:38 2016 +0000
@@ -19,7 +19,7 @@ 
   $ cd c
   $ hg push --config paths.default=
   abort: default repository not configured!
-  (see the "path" section in "hg help config")
+  (see 'hg help config.paths')
   [255]
 
   $ cd ..