Patchwork [1,of,2,v3] crecord: delete commented line

login
register
mail settings
Submitter Nathan Goldbaum
Date Sept. 19, 2016, 9:38 p.m.
Message ID <dec5dfcbd772a9f51674.1474321139@ROUS2>
Download mbox | patch
Permalink /patch/16671/
State Superseded
Delegated to: Ryan McElroy
Headers show

Comments

Nathan Goldbaum - Sept. 19, 2016, 9:38 p.m.
# HG changeset patch
# User Nathan Goldbaum <ngoldbau@illinois.edu>
# Date 1473871187 18000
#      Wed Sep 14 11:39:47 2016 -0500
# Node ID dec5dfcbd772a9f51674067ad18dff6d9bad78cf
# Parent  2c302c6544511b37abe61ee2cc5278e4f61d5e71
crecord: delete commented line
Sean Farley - Sept. 19, 2016, 10:04 p.m.
Nathan Goldbaum <nathan12343@gmail.com> writes:

> # HG changeset patch
> # User Nathan Goldbaum <ngoldbau@illinois.edu>
> # Date 1473871187 18000
> #      Wed Sep 14 11:39:47 2016 -0500
> # Node ID dec5dfcbd772a9f51674067ad18dff6d9bad78cf
> # Parent  2c302c6544511b37abe61ee2cc5278e4f61d5e71
> crecord: delete commented line
>
> diff -r 2c302c654451 -r dec5dfcbd772 mercurial/crecord.py
> --- a/mercurial/crecord.py	Wed Sep 14 17:12:39 2016 +0200
> +++ b/mercurial/crecord.py	Wed Sep 14 11:39:47 2016 -0500
> @@ -719,7 +719,7 @@ class curseschunkselector(object):
>          "scroll the screen to fully show the currently-selected"
>          selstart = self.selecteditemstartline
>          selend = self.selecteditemendline
> -        #selnumlines = selend - selstart
> +

I think this has already been queued:

https://www.mercurial-scm.org/repo/hg-committed/rev/3664537386ab
Nathan Goldbaum - Sept. 19, 2016, 10:20 p.m.
Ah, oops, thank you!

I will send a v4 with just the one new commit.

On Mon, Sep 19, 2016 at 5:04 PM, Sean Farley <sean@farley.io> wrote:

> Nathan Goldbaum <nathan12343@gmail.com> writes:
>
> > # HG changeset patch
> > # User Nathan Goldbaum <ngoldbau@illinois.edu>
> > # Date 1473871187 18000
> > #      Wed Sep 14 11:39:47 2016 -0500
> > # Node ID dec5dfcbd772a9f51674067ad18dff6d9bad78cf
> > # Parent  2c302c6544511b37abe61ee2cc5278e4f61d5e71
> > crecord: delete commented line
> >
> > diff -r 2c302c654451 -r dec5dfcbd772 mercurial/crecord.py
> > --- a/mercurial/crecord.py    Wed Sep 14 17:12:39 2016 +0200
> > +++ b/mercurial/crecord.py    Wed Sep 14 11:39:47 2016 -0500
> > @@ -719,7 +719,7 @@ class curseschunkselector(object):
> >          "scroll the screen to fully show the currently-selected"
> >          selstart = self.selecteditemstartline
> >          selend = self.selecteditemendline
> > -        #selnumlines = selend - selstart
> > +
>
> I think this has already been queued:
>
> https://www.mercurial-scm.org/repo/hg-committed/rev/3664537386ab
>

Patch

diff -r 2c302c654451 -r dec5dfcbd772 mercurial/crecord.py
--- a/mercurial/crecord.py	Wed Sep 14 17:12:39 2016 +0200
+++ b/mercurial/crecord.py	Wed Sep 14 11:39:47 2016 -0500
@@ -719,7 +719,7 @@  class curseschunkselector(object):
         "scroll the screen to fully show the currently-selected"
         selstart = self.selecteditemstartline
         selend = self.selecteditemendline
-        #selnumlines = selend - selstart
+
         padstart = self.firstlineofpadtoprint
         padend = padstart + self.yscreensize - self.numstatuslines - 1
         # 'buffered' pad start/end values which scroll with a certain