From patchwork Thu May 23 01:53:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [2,of,2,V2] blackbox: fix blackbox causing exceptions in tests From: Durham Goode X-Patchwork-Id: 1664 Message-Id: <88afc49be6cfab7e4218.1369273997@dev350.prn1.facebook.com> To: mercurial-devel@selenic.com Date: Wed, 22 May 2013 18:53:17 -0700 # HG changeset patch # User Durham Goode # Date 1369269504 25200 # Wed May 22 17:38:24 2013 -0700 # Node ID 88afc49be6cfab7e42180ae82d0a17aa662c24d4 # Parent 5a27f1294beaf297888aed7dc0f2247bdb4032e8 blackbox: fix blackbox causing exceptions in tests In the tests some scripts call reposetup with the base ui instead of the one the extensions have modified. This causes an exception in blackbox.reposetup since it expected a method to be there. So I just check for it first. This only happened when the blackbox extension was enabled during tests. diff --git a/hgext/blackbox.py b/hgext/blackbox.py --- a/hgext/blackbox.py +++ b/hgext/blackbox.py @@ -126,7 +126,8 @@ if not repo.local(): return - ui.setrepo(repo) + if util.safehasattr(ui, 'setrepo'): + ui.setrepo(repo) @command('^blackbox', [('l', 'limit', 10, _('the number of events to show')),