Patchwork [4,of,4] debugrevspec: deprecate --optimize option

login
register
mail settings
Submitter Yuya Nishihara
Date Sept. 8, 2016, 3:14 p.m.
Message ID <06ffd3f76a7c117d3b11.1473347666@mimosa>
Download mbox | patch
Permalink /patch/16579/
State Accepted
Headers show

Comments

Yuya Nishihara - Sept. 8, 2016, 3:14 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1471750583 -32400
#      Sun Aug 21 12:36:23 2016 +0900
# Node ID 06ffd3f76a7c117d3b11bebae909a4fb32c5f82a
# Parent  737f256f394d4401e554413fc77cfc85b8337d32
debugrevspec: deprecate --optimize option

This option has been superseded by '--show-stage NAME', and will cause
confusion in future patches.
Simon Farnsworth - Sept. 12, 2016, 7:54 a.m.
The patch series looks good to me.

On 08/09/2016 16:14, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1471750583 -32400
> #      Sun Aug 21 12:36:23 2016 +0900
> # Node ID 06ffd3f76a7c117d3b11bebae909a4fb32c5f82a
> # Parent  737f256f394d4401e554413fc77cfc85b8337d32
> debugrevspec: deprecate --optimize option
>
> This option has been superseded by '--show-stage NAME', and will cause
> confusion in future patches.
>
> diff --git a/mercurial/commands.py b/mercurial/commands.py
> --- a/mercurial/commands.py
> +++ b/mercurial/commands.py
> @@ -3511,7 +3511,8 @@ def debugrevlog(ui, repo, file_=None, **
>                                                               numdeltas))
>
>  @command('debugrevspec',
> -    [('', 'optimize', None, _('print parsed tree after optimizing')),
> +    [('', 'optimize', None,
> +      _('print parsed tree after optimizing (DEPRECATED)')),
>       ('p', 'show-stage', [],
>        _('print parsed tree at the given stage'), _('NAME')),
>       ],
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://urldefense.proofpoint.com/v2/url?u=https-3A__www.mercurial-2Dscm.org_mailman_listinfo_mercurial-2Ddevel&d=DQIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=mEgSWILcY4c4W3zjApBQLA&m=lksGz0wx4ZsmRn1DXr-JqhqR0l2yu5bgXbi_gdaIvtw&s=0tFUz_cTD-9z4nYhagjVkuL-1egDU67jhiH_lVAd3Lg&e=
>
Yuya Nishihara - Sept. 12, 2016, 1:04 p.m.
On Mon, 12 Sep 2016 08:54:41 +0100, Simon Farnsworth wrote:
> The patch series looks good to me.

Thanks, and there must be a ninja last week.

> On 08/09/2016 16:14, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya@tcha.org>
> > # Date 1471750583 -32400
> > #      Sun Aug 21 12:36:23 2016 +0900
> > # Node ID 06ffd3f76a7c117d3b11bebae909a4fb32c5f82a
> > # Parent  737f256f394d4401e554413fc77cfc85b8337d32
> > debugrevspec: deprecate --optimize option

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -3511,7 +3511,8 @@  def debugrevlog(ui, repo, file_=None, **
                                                              numdeltas))
 
 @command('debugrevspec',
-    [('', 'optimize', None, _('print parsed tree after optimizing')),
+    [('', 'optimize', None,
+      _('print parsed tree after optimizing (DEPRECATED)')),
      ('p', 'show-stage', [],
       _('print parsed tree at the given stage'), _('NAME')),
      ],