From patchwork Tue Aug 16 08:00:35 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [1,of,3] check-code: make dict() pattern less invasive
From: Yuya Nishihara <yuya@tcha.org>
X-Patchwork-Id: 16315
Message-Id: <9f9284385805b57572eb.1471334435@mimosa>
To: mercurial-devel@mercurial-scm.org
Date: Tue, 16 Aug 2016 17:00:35 +0900

# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1471249059 -32400
#      Mon Aug 15 17:17:39 2016 +0900
# Node ID 9f9284385805b57572eb255ce35be3927ce0785b
# Parent  3747d3543f8b6d28709490b637197cfb0bc4ba64
check-code: make dict() pattern less invasive

'foodict(x=y)' should be allowed.

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -237,7 +237,7 @@ pypats = [
      "tuple parameter unpacking not available in Python 3+"),
     (r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),
     (r'\breduce\s*\(.*', "reduce is not available in Python 3+"),
-    (r'dict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',
+    (r'\bdict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',
      'dict-from-generator'),
     (r'\.has_key\b', "dict.has_key is not available in Python 3+"),
     (r'\s<>\s', '<> operator is not available in Python 3+, use !='),