Patchwork help: include --interactive in non-verbose help for revert (issue5306)

login
register
mail settings
Submitter Pulkit Goyal
Date July 19, 2016, 10:18 p.m.
Message ID <81655a844fe94211ced1.1468966727@pulkit-goyal>
Download mbox | patch
Permalink /patch/15958/
State Changes Requested
Headers show

Comments

Pulkit Goyal - July 19, 2016, 10:18 p.m.
# HG changeset patch
# User Pulkit Goyal <7895pulkit@gmail.com>
# Date 1468966489 -19800
#      Wed Jul 20 03:44:49 2016 +0530
# Branch stable
# Node ID 81655a844fe94211ced143097e043a519257cd22
# Parent  334632380e22e4aa960068fc7e173bbe8a13d983
help: include --interactive in non-verbose help for revert (issue5306)

The flag was marked as experimental, but its more than 15 months that feature was added.
So we should include it in the help and also unmark it as experimental. The initial patch
 can be seen here https://www.selenic.com/hg/rev/521fe8287dd5
Augie Fackler - July 20, 2016, 3:24 p.m.
On Wed, Jul 20, 2016 at 03:48:47AM +0530, Pulkit Goyal wrote:
> # HG changeset patch
> # User Pulkit Goyal <7895pulkit@gmail.com>
> # Date 1468966489 -19800
> #      Wed Jul 20 03:44:49 2016 +0530
> # Branch stable
> # Node ID 81655a844fe94211ced143097e043a519257cd22
> # Parent  334632380e22e4aa960068fc7e173bbe8a13d983
> help: include --interactive in non-verbose help for revert (issue5306)

I think we've left this as experimental while we've been doing UI
tweaks. Pierre-Yves, are we comfortable locking this in now?

(I can't remember if we are or not - I'll try to play with revert
--interactive some more soon.)

>
> The flag was marked as experimental, but its more than 15 months that feature was added.
> So we should include it in the help and also unmark it as experimental. The initial patch
>  can be seen here https://www.selenic.com/hg/rev/521fe8287dd5
>
> diff -r 334632380e22 -r 81655a844fe9 mercurial/commands.py
> --- a/mercurial/commands.py	Tue Jul 19 21:16:44 2016 +0900
> +++ b/mercurial/commands.py	Wed Jul 20 03:44:49 2016 +0530
> @@ -6301,7 +6301,7 @@
>      ('r', 'rev', '', _('revert to the specified revision'), _('REV')),
>      ('C', 'no-backup', None, _('do not save backup copies of files')),
>      ('i', 'interactive', None,
> -            _('interactively select the changes (EXPERIMENTAL)')),
> +            _('interactively select the changes')),
>      ] + walkopts + dryrunopts,
>      _('[OPTION]... [-r REV] [NAME]...'))
>  def revert(ui, repo, *pats, **opts):
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Denis Laxalde - July 20, 2016, 4:07 p.m.
Augie Fackler a écrit :
> On Wed, Jul 20, 2016 at 03:48:47AM +0530, Pulkit Goyal wrote:
>> > # HG changeset patch
>> > # User Pulkit Goyal <7895pulkit@gmail.com>
>> > # Date 1468966489 -19800
>> > #      Wed Jul 20 03:44:49 2016 +0530
>> > # Branch stable
>> > # Node ID 81655a844fe94211ced143097e043a519257cd22
>> > # Parent  334632380e22e4aa960068fc7e173bbe8a13d983
>> > help: include --interactive in non-verbose help for revert (issue5306)
> I think we've left this as experimental while we've been doing UI
> tweaks. Pierre-Yves, are we comfortable locking this in now?
>
> (I can't remember if we are or not - I'll try to play with revert
> --interactive some more soon.)
>

There's still the "reversed diff" issue discussed at 
https://bz.mercurial-scm.org/show_bug.cgi?id=5096

Patch

diff -r 334632380e22 -r 81655a844fe9 mercurial/commands.py
--- a/mercurial/commands.py	Tue Jul 19 21:16:44 2016 +0900
+++ b/mercurial/commands.py	Wed Jul 20 03:44:49 2016 +0530
@@ -6301,7 +6301,7 @@ 
     ('r', 'rev', '', _('revert to the specified revision'), _('REV')),
     ('C', 'no-backup', None, _('do not save backup copies of files')),
     ('i', 'interactive', None,
-            _('interactively select the changes (EXPERIMENTAL)')),
+            _('interactively select the changes')),
     ] + walkopts + dryrunopts,
     _('[OPTION]... [-r REV] [NAME]...'))
 def revert(ui, repo, *pats, **opts):