Patchwork [6,of,6] dirstate._walkexplicit: inline dirsnotfound.append

login
register
mail settings
Submitter Siddharth Agarwal
Date May 7, 2013, 9:32 p.m.
Message ID <56fcfdc169ed153930aa.1367962333@dev1091.prn1.facebook.com>
Download mbox | patch
Permalink /patch/1588/
State Accepted
Commit 63f7bd2e1a465f088a4e1b66e12ea18e896ab93f
Headers show

Comments

Siddharth Agarwal - May 7, 2013, 9:32 p.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1367961634 25200
#      Tue May 07 14:20:34 2013 -0700
# Node ID 56fcfdc169ed153930aa7f2778590219040b2a5f
# Parent  97f4593c28baba2cdda1d893241680dda0c3e2cb
dirstate._walkexplicit: inline dirsnotfound.append
Matt Mackall - May 9, 2013, 10:09 p.m.
On Tue, 2013-05-07 at 14:32 -0700, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0@fb.com>
> # Date 1367961634 25200
> #      Tue May 07 14:20:34 2013 -0700
> # Node ID 56fcfdc169ed153930aa7f2778590219040b2a5f
> # Parent  97f4593c28baba2cdda1d893241680dda0c3e2cb
> dirstate._walkexplicit: inline dirsnotfound.append

These are queued for default, thanks.

Patch

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -559,6 +559,7 @@ 
         dirsfound = []
         foundadd = dirsfound.append
         dirsnotfound = []
+        notfoundadd = dirsnotfound.append
 
         if match.matchfn != match.exact and self._checkcase:
             normalize = self._normalize
@@ -615,7 +616,7 @@ 
                         if fn.startswith(prefix):
                             if matchedir:
                                 matchedir(nf)
-                            dirsnotfound.append(nf)
+                            notfoundadd(nf)
                             break
                     else:
                         badfn(ff, inst.strerror)