Patchwork match: add comments to explain explicitdir and traversedir

login
register
mail settings
Submitter Siddharth Agarwal
Date May 3, 2013, 10:38 p.m.
Message ID <f53ecf1b838b0fb88d07.1367620707@sid0x220>
Download mbox | patch
Permalink /patch/1555/
State Accepted
Commit facd906caeebdd22519f5bf4836b1c1ad41a4e55
Headers show

Comments

Siddharth Agarwal - May 3, 2013, 10:38 p.m.
# HG changeset patch
# User Siddharth Agarwal <sid0@fb.com>
# Date 1367620578 25200
#      Fri May 03 15:36:18 2013 -0700
# Node ID f53ecf1b838b0fb88d07821b891c346714862fd1
# Parent  2157f457e73c99b160229dcc5db4b4c49202e6ff
match: add comments to explain explicitdir and traversedir
Siddharth Agarwal - May 3, 2013, 10:41 p.m.
On 05/03/2013 03:38 PM, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0@fb.com>
> # Date 1367620578 25200
> #      Fri May 03 15:36:18 2013 -0700
> # Node ID f53ecf1b838b0fb88d07821b891c346714862fd1
> # Parent  2157f457e73c99b160229dcc5db4b4c49202e6ff
> match: add comments to explain explicitdir and traversedir

(this goes after patch 8)
Matt Mackall - May 4, 2013, 11:27 p.m.
On Fri, 2013-05-03 at 15:38 -0700, Siddharth Agarwal wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0@fb.com>
> # Date 1367620578 25200
> #      Fri May 03 15:36:18 2013 -0700
> # Node ID f53ecf1b838b0fb88d07821b891c346714862fd1
> # Parent  2157f457e73c99b160229dcc5db4b4c49202e6ff
> match: add comments to explain explicitdir and traversedir

These are all queued for default, thanks.

Patch

diff -r 2157f457e73c -r f53ecf1b838b mercurial/match.py
--- a/mercurial/match.py	Sun Apr 28 15:45:17 2013 -0700
+++ b/mercurial/match.py	Fri May 03 15:36:18 2013 -0700
@@ -119,7 +119,11 @@  class match(object):
         found/accessed, with an error message
         '''
         pass
+    # If this is set, it will be called when an explicitly listed directory is
+    # visited.
     explicitdir = None
+    # If this is set, it will be called when a directory discovered by recursive
+    # traversal is visited.
     traversedir = None
     def missing(self, f):
         pass