Patchwork tests: increase test-https malform error glob

login
register
mail settings
Submitter Durham Goode
Date June 15, 2016, 1:16 a.m.
Message ID <12b83c42143218c729e5.1465953373@dev8486.prn1.facebook.com>
Download mbox | patch
Permalink /patch/15509/
State Accepted
Headers show

Comments

Durham Goode - June 15, 2016, 1:16 a.m.
# HG changeset patch
# User Durham Goode <durham@fb.com>
# Date 1465953282 25200
#      Tue Jun 14 18:14:42 2016 -0700
# Node ID 12b83c42143218c729e5eb72de373529a7579ef9
# Parent  8bf84295e59ba0c98e64fd7ccf3f809e4da5b237
tests: increase test-https malform error glob

The recently introduced (ecc9b788fd690a0a) test around malformed pem files hard
codes an error message which doesn't appear to be cross platform agnostic. On
our machines (centos6 if it matters) the test output differs:

-  abort: error: unknown error* (glob)
+  abort: error: _ssl.c:330: error:00000000:lib(0):func(0):reason(0)

This patch increases the glob to cover the entire error message.
Yuya Nishihara - June 16, 2016, 1:53 p.m.
On Tue, 14 Jun 2016 18:16:13 -0700, Durham Goode wrote:
> # HG changeset patch
> # User Durham Goode <durham@fb.com>
> # Date 1465953282 25200
> #      Tue Jun 14 18:14:42 2016 -0700
> # Node ID 12b83c42143218c729e5eb72de373529a7579ef9
> # Parent  8bf84295e59ba0c98e64fd7ccf3f809e4da5b237
> tests: increase test-https malform error glob

Looks good, queued, thanks.

Patch

diff --git a/tests/test-https.t b/tests/test-https.t
--- a/tests/test-https.t
+++ b/tests/test-https.t
@@ -63,7 +63,7 @@  A malformed per-host certificate file wi
 
   $ echo baddata > badca.pem
   $ hg --config hostsecurity.localhost:verifycertsfile=badca.pem clone https://localhost:$HGPORT/
-  abort: error: unknown error* (glob)
+  abort: error: * (glob)
   [255]
 
 A per-host certificate mismatching the server will fail verification