Patchwork tests: test-run-tests: clean up inuse server eagerly

login
register
mail settings
Submitter timeless
Date June 3, 2016, 2:11 p.m.
Message ID <cb9eb592d4d3fa8f73b5.1464963116@gcc2-power8.osuosl.org>
Download mbox | patch
Permalink /patch/15369/
State Accepted
Delegated to: Augie Fackler
Headers show

Comments

timeless - June 3, 2016, 2:11 p.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1462980025 0
#      Wed May 11 15:20:25 2016 +0000
# Node ID cb9eb592d4d3fa8f73b52dfc67f13e67da262f41
# Parent  bee3ca724aab40d85f2899b371a408b721b5eb9b
# EXP-Topic runtests
# Available At https://bitbucket.org/timeless/mercurial-crew
#              hg pull https://bitbucket.org/timeless/mercurial-crew -r cb9eb592d4d3
tests: test-run-tests: clean up inuse server eagerly
Augie Fackler - June 4, 2016, 2:31 a.m.
On Fri, Jun 03, 2016 at 02:11:56PM +0000, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1462980025 0
> #      Wed May 11 15:20:25 2016 +0000
> # Node ID cb9eb592d4d3fa8f73b52dfc67f13e67da262f41
> # Parent  bee3ca724aab40d85f2899b371a408b721b5eb9b
> # EXP-Topic runtests
> # Available At https://bitbucket.org/timeless/mercurial-crew
> #              hg pull https://bitbucket.org/timeless/mercurial-crew -r cb9eb592d4d3
> tests: test-run-tests: clean up inuse server eagerly

OOC, why?

>
> diff -r bee3ca724aab -r cb9eb592d4d3 tests/test-run-tests.t
> --- a/tests/test-run-tests.t	Wed May 11 16:40:16 2016 +0000
> +++ b/tests/test-run-tests.t	Wed May 11 15:20:25 2016 +0000
> @@ -301,6 +301,8 @@
>    .
>    # Ran 1 tests, 0 skipped, 0 warned, 0 failed.
>    $ rm test-serve-inuse.t
> +  $ killdaemons.py $DAEMON_PIDS
> +  $ rm $DAEMON_PIDS
>
>  Running In Debug Mode
>  ======================
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
timeless - June 5, 2016, 5:18 p.m.
Stray processes don't get killed well when I use ^C. I end up with a whole
bunch of daemons just sitting around on gcc112... Also often my session
used to get disconnected in bad ways which tended to leave servers around...
On Jun 3, 2016 10:31 PM, "Augie Fackler" <raf@durin42.com> wrote:

On Fri, Jun 03, 2016 at 02:11:56PM +0000, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1462980025 0
> #      Wed May 11 15:20:25 2016 +0000
> # Node ID cb9eb592d4d3fa8f73b52dfc67f13e67da262f41
> # Parent  bee3ca724aab40d85f2899b371a408b721b5eb9b
> # EXP-Topic runtests
> # Available At https://bitbucket.org/timeless/mercurial-crew
> #              hg pull https://bitbucket.org/timeless/mercurial-crew -r
cb9eb592d4d3
> tests: test-run-tests: clean up inuse server eagerly

OOC, why?

>
> diff -r bee3ca724aab -r cb9eb592d4d3 tests/test-run-tests.t
> --- a/tests/test-run-tests.t  Wed May 11 16:40:16 2016 +0000
> +++ b/tests/test-run-tests.t  Wed May 11 15:20:25 2016 +0000
> @@ -301,6 +301,8 @@
>    .
>    # Ran 1 tests, 0 skipped, 0 warned, 0 failed.
>    $ rm test-serve-inuse.t
> +  $ killdaemons.py $DAEMON_PIDS
> +  $ rm $DAEMON_PIDS
>
>  Running In Debug Mode
>  ======================
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Augie Fackler - June 5, 2016, 11:10 p.m.
> On Jun 5, 2016, at 1:18 PM, timeless <timeless@gmail.com> wrote:
> 
> Stray processes don't get killed well when I use ^C. I end up with a whole bunch of daemons just sitting around on gcc112... Also often my session used to get disconnected in bad ways which tended to leave servers around...
> 
For the first case, are you sending a single ^C or many ^Cs? If the former, we might have a bug.

For the second case, it turns out gcc112 has mosh on it, so I’d recommend giving https://mosh.mit.edu/ a run. Should make things a good bit nicer for you.

> On Jun 3, 2016 10:31 PM, "Augie Fackler" <raf@durin42.com <mailto:raf@durin42.com>> wrote:
> On Fri, Jun 03, 2016 at 02:11:56PM +0000, timeless wrote:
> > # HG changeset patch
> > # User timeless <timeless@mozdev.org <mailto:timeless@mozdev.org>>
> > # Date 1462980025 0
> > #      Wed May 11 15:20:25 2016 +0000
> > # Node ID cb9eb592d4d3fa8f73b52dfc67f13e67da262f41
> > # Parent  bee3ca724aab40d85f2899b371a408b721b5eb9b
> > # EXP-Topic runtests
> > # Available At https://bitbucket.org/timeless/mercurial-crew <https://bitbucket.org/timeless/mercurial-crew>
> > #              hg pull https://bitbucket.org/timeless/mercurial-crew <https://bitbucket.org/timeless/mercurial-crew> -r cb9eb592d4d3
> > tests: test-run-tests: clean up inuse server eagerly
> 
> OOC, why?
> 
> >
> > diff -r bee3ca724aab -r cb9eb592d4d3 tests/test-run-tests.t
> > --- a/tests/test-run-tests.t  Wed May 11 16:40:16 2016 +0000
> > +++ b/tests/test-run-tests.t  Wed May 11 15:20:25 2016 +0000
> > @@ -301,6 +301,8 @@
> >    .
> >    # Ran 1 tests, 0 skipped, 0 warned, 0 failed.
> >    $ rm test-serve-inuse.t
> > +  $ killdaemons.py $DAEMON_PIDS
> > +  $ rm $DAEMON_PIDS
> >
> >  Running In Debug Mode
> >  ======================
> > _______________________________________________
> > Mercurial-devel mailing list
> > Mercurial-devel@mercurial-scm.org <mailto:Mercurial-devel@mercurial-scm.org>
> > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org <mailto:Mercurial-devel@mercurial-scm.org>
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>

Patch

diff -r bee3ca724aab -r cb9eb592d4d3 tests/test-run-tests.t
--- a/tests/test-run-tests.t	Wed May 11 16:40:16 2016 +0000
+++ b/tests/test-run-tests.t	Wed May 11 15:20:25 2016 +0000
@@ -301,6 +301,8 @@ 
   .
   # Ran 1 tests, 0 skipped, 0 warned, 0 failed.
   $ rm test-serve-inuse.t
+  $ killdaemons.py $DAEMON_PIDS
+  $ rm $DAEMON_PIDS
 
 Running In Debug Mode
 ======================