Patchwork Build failure on xenial

login
register
mail settings
Submitter Sean Farley
Date June 1, 2016, 9:21 p.m.
Message ID <m2vb1svc4f.fsf@farley.io>
Download mbox | patch
Permalink /patch/15326/
State Not Applicable
Headers show

Comments

Sean Farley - June 1, 2016, 9:21 p.m.
Got another failure, this time with locking:

cd tests && python run-tests.py -j4
sss...s...s..s..ss.s..ss.ss..s...s...s......sss..s.......s..s...s.

https://launchpadlibrarian.net/262769907/buildlog_ubuntu-trusty-i386.mercurial_3.8.2+208-trusty-438caf194160_BUILDING.txt.gz
Matt Mackall - June 1, 2016, 9:35 p.m.
On Wed, 2016-06-01 at 14:21 -0700, Sean Farley wrote:
> Got another failure, this time with locking:
> 
> cd tests && python run-tests.py -j4
> sss...s...s..s..ss.s..ss.ss..s...s...s......sss..s.......s..s...s.
> --- /«BUILDDIR»/mercurial-3.8.2+208-trusty/tests/test-clone.t
> +++ /«BUILDDIR»/mercurial-3.8.2+208-trusty/tests/test-clone.t.err
> @@ -1075,8 +1075,6 @@
>  
>    $ cat race2.log
>    (sharing from existing pooled repository
> b5f04eac9d8f7a6a9fcb070243cccea7dc5ea0c1)
> -  waiting for lock on repository share-destrace2 held by * (glob)
> -  got lock after \d+ seconds (re)
>    searching for changes
>    no changes found
>    adding remote bookmark bookA

Yep, due to load on your build host, this test has run over the internal lock
delays and released the lock.

In other tests of this sort, we use hook tricks to actually reliably stop the
racing task in the middle so that we can guarantee the race happens (and let us
get rid of test-suite-slowing sleeps).

Here perhaps we could do that by having the lockdelay extension stop itself
after lock acquisition and the kick the locking task on contention.

-- 
Mathematics is the supreme nostalgia of our time.
Jun Wu - June 1, 2016, 9:54 p.m.
FWIW, according to my note, I got the exactly same error while running tests
(without using chg) on my devserver on some day before Mar. 11 and I ignored
it because I was focusing on chg failures only.

Sadly I am not able to reproduce it using @ (438caf) on my laptop, CentOS 6
and 7 devservers at present.

(This message also serves as a test of my lovely new email configuration)

Excerpts from Sean Farley's message of 2016-06-01 14:21:36 -0700:
> Got another failure, this time with locking:
> 
> cd tests && python run-tests.py -j4
> sss...s...s..s..ss.s..ss.ss..s...s...s......sss..s.......s..s...s.
> --- /«BUILDDIR»/mercurial-3.8.2+208-trusty/tests/test-clone.t
> +++ /«BUILDDIR»/mercurial-3.8.2+208-trusty/tests/test-clone.t.err
> @@ -1075,8 +1075,6 @@
>  
>    $ cat race2.log
>    (sharing from existing pooled repository b5f04eac9d8f7a6a9fcb070243cccea7dc5ea0c1)
> -  waiting for lock on repository share-destrace2 held by * (glob)
> -  got lock after \d+ seconds (re)
>    searching for changes
>    no changes found
>    adding remote bookmark bookA
> 
> https://launchpadlibrarian.net/262769907/buildlog_ubuntu-trusty-i386.mercurial_3.8.2+208-trusty-438caf194160_BUILDING.txt.gz

Patch

--- /«BUILDDIR»/mercurial-3.8.2+208-trusty/tests/test-clone.t
+++ /«BUILDDIR»/mercurial-3.8.2+208-trusty/tests/test-clone.t.err
@@ -1075,8 +1075,6 @@ 
 
   $ cat race2.log
   (sharing from existing pooled repository b5f04eac9d8f7a6a9fcb070243cccea7dc5ea0c1)
-  waiting for lock on repository share-destrace2 held by * (glob)
-  got lock after \d+ seconds (re)
   searching for changes
   no changes found
   adding remote bookmark bookA