Patchwork [hglib] tests: fix test-bookmarks to match changed hg behavior

login
register
mail settings
Submitter Alexander Plavin
Date May 2, 2013, 5:45 p.m.
Message ID <a84ebf2abbfdabe87075.1367516718@debian-alexander.dolgopa>
Download mbox | patch
Permalink /patch/1532/
State Accepted, archived
Headers show

Comments

Alexander Plavin - May 2, 2013, 5:45 p.m.
# HG changeset patch
# User Alexander Plavin <me@aplavin.ru>
# Date 1367516693 -14400
#      Thu May 02 21:44:53 2013 +0400
# Node ID a84ebf2abbfdabe8707568f44e203460f705b965
# Parent  45b03c46963f8a4e370c98058ff07fdf87c201f9
tests: fix test-bookmarks to match changed hg behavior

After a fix in hg related to activating bookmarks, a test started failing
Matt Mackall - May 2, 2013, 9:28 p.m.
On Thu, 2013-05-02 at 21:45 +0400, Alexander Plavin wrote:
> # HG changeset patch
> # User Alexander Plavin <me@aplavin.ru>
> # Date 1367516693 -14400
> #      Thu May 02 21:44:53 2013 +0400
> # Node ID a84ebf2abbfdabe8707568f44e203460f705b965
> # Parent  45b03c46963f8a4e370c98058ff07fdf87c201f9
> tests: fix test-bookmarks to match changed hg behavior

Queued for hglib, thanks.
Idan Kamara - May 3, 2013, 7:57 a.m.
On Thu, May 2, 2013 at 8:45 PM, Alexander Plavin <me@aplavin.ru> wrote:

> # HG changeset patch
> # User Alexander Plavin <me@aplavin.ru>
> # Date 1367516693 -14400
> #      Thu May 02 21:44:53 2013 +0400
> # Node ID a84ebf2abbfdabe8707568f44e203460f705b965
> # Parent  45b03c46963f8a4e370c98058ff07fdf87c201f9
> tests: fix test-bookmarks to match changed hg behavior
>
> After a fix in hg related to activating bookmarks, a test started failing
>

This fails for older versions of hg that predated this change.
Alexander Plavin - May 3, 2013, 7:59 a.m.
Sorry, I forgot again that hglib is tested against multiple hg versions.


2013/5/3 Idan Kamara <idankk86@gmail.com>

> On Thu, May 2, 2013 at 8:45 PM, Alexander Plavin <me@aplavin.ru> wrote:
>
>> # HG changeset patch
>> # User Alexander Plavin <me@aplavin.ru>
>> # Date 1367516693 -14400
>> #      Thu May 02 21:44:53 2013 +0400
>> # Node ID a84ebf2abbfdabe8707568f44e203460f705b965
>> # Parent  45b03c46963f8a4e370c98058ff07fdf87c201f9
>> tests: fix test-bookmarks to match changed hg behavior
>>
>> After a fix in hg related to activating bookmarks, a test started failing
>>
>
> This fails for older versions of hg that predated this change.
>

Patch

diff -r 45b03c46963f -r a84ebf2abbfd tests/test-bookmarks.py
--- a/tests/test-bookmarks.py	Sat Apr 27 16:49:36 2013 +0400
+++ b/tests/test-bookmarks.py	Thu May 02 21:44:53 2013 +0400
@@ -17,7 +17,7 @@ 
         self.client.bookmark('one', rev1)
         self.assertEquals(self.client.bookmarks(),
                           ([('one', rev1, node1[:12]),
-                            ('zero', rev0, node0[:12])], 0))
+                            ('zero', rev0, node0[:12])], -1))
 
     #def test_spaces(self):
     #    self.client.bookmark('s pace', self.rev0)