Patchwork [website] frontpage: don't cut off text in quick start snippet, resize the column instead

login
register
mail settings
Submitter Anton Shestakov
Date May 28, 2016, 1:33 a.m.
Message ID <19ea041943ed16f4cb5c.1464399198@neuro>
Download mbox | patch
Permalink /patch/15228/
State Accepted
Headers show

Comments

Anton Shestakov - May 28, 2016, 1:33 a.m.
# HG changeset patch
# User Anton Shestakov <av6@dwimlabs.net>
# Date 1464398893 -28800
#      Sat May 28 09:28:13 2016 +0800
# Node ID 19ea041943ed16f4cb5c1404d9be6caee11ec44d
# Parent  c3c50748a20b4eedb749762e912691873516e9bc
frontpage: don't cut off text in quick start snippet, resize the column instead

Otherwise it looks like it says 'hg clone https://selenic.com/repo/hell'.
Sean Farley - May 31, 2016, 8:52 p.m.
Anton Shestakov <av6@dwimlabs.net> writes:

> # HG changeset patch
> # User Anton Shestakov <av6@dwimlabs.net>
> # Date 1464398893 -28800
> #      Sat May 28 09:28:13 2016 +0800
> # Node ID 19ea041943ed16f4cb5c1404d9be6caee11ec44d
> # Parent  c3c50748a20b4eedb749762e912691873516e9bc
> frontpage: don't cut off text in quick start snippet, resize the column instead
>
> Otherwise it looks like it says 'hg clone https://selenic.com/repo/hell'.

Wow, I didn't realize it was this easy to fix. I tested it locally and
queued this unless someone has an objection.
Anton Shestakov - May 31, 2016, 11:12 p.m.
On Tue, 31 May 2016 13:52:12 -0700
Sean Farley <sean@farley.io> wrote:

> Anton Shestakov <av6@dwimlabs.net> writes:
> 
> > # HG changeset patch
> > # User Anton Shestakov <av6@dwimlabs.net>
> > # Date 1464398893 -28800
> > #      Sat May 28 09:28:13 2016 +0800
> > # Node ID 19ea041943ed16f4cb5c1404d9be6caee11ec44d
> > # Parent  c3c50748a20b4eedb749762e912691873516e9bc
> > frontpage: don't cut off text in quick start snippet, resize the
> > column instead
> >
> > Otherwise it looks like it says 'hg clone
> > https://selenic.com/repo/hell'.  
> 
> Wow, I didn't realize it was this easy to fix.

Well, the problem now is if the lines in "quick start" get longer, the
whole column will be placed below the left block. In fact it happens if
you add just one character more to the longest line. I'll send another
patch to make this less likely to happen.

Patch

diff --git a/static/css/styles.css b/static/css/styles.css
--- a/static/css/styles.css
+++ b/static/css/styles.css
@@ -98,6 +98,7 @@  blockquote, q { quotes: "" ""; }
 .big { float: left; width: 470px; }
 .quote { float: right; width: 740px; text-align: right; margin-right: 25px;   }
 .big h2 { margin-top: 20px; }
+.autowidth { width: auto; margin-right: 0; }
 
 /*
  * Logo
diff --git a/templates/frontpage.html b/templates/frontpage.html
--- a/templates/frontpage.html
+++ b/templates/frontpage.html
@@ -35,7 +35,7 @@ 
             </li>
         </ol>
     </div>
-    <div class="col">
+    <div class="col autowidth">
         <h3>Quick Start</h3>
 
         <p><em>Clone a project and push changes</em>