| Submitter | Sean Farley |
|---|---|
| Date | May 18, 2016, 7:46 p.m. |
| Message ID | <m2h9dv2lp9.fsf@farley.io> |
| Download | mbox | patch |
| Permalink | /patch/15172/ |
| State | Not Applicable |
| Headers | show |
Comments
19.05.2016, 03:46, "Sean Farley" <sean@farley.io>: > It seems after 9d38a2061fd8 (patch: show lower-ed translated message > correctly) I'm getting the following error below. I don't know the > launchpad builders so any help here is appreciated! > > cd tests && python run-tests.py -j4 > sss...s.....ss..ss.s..sss.s..s...s........s.ss > --- /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t > +++ /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t.err > @@ -899,7 +899,7 @@ > > ? > > q > > EOF > - y - \x82\xb1\x82\xcc\x95\xcf\x8dX\x82\xf0\x8bL\x98^(yes) (esc) > + Binary file (standard input) matches I've found that -a/--text option for grep fixes this, but that's GNU grep, not sure if other implementations have the option. Quick search reveals that FreeBSD uses GNU grep [1] and OpenBSD has -a option for its implementation [2], but OpenSolaris doesn't have any way to force text [3]. https://www.mercurial-scm.org/wiki/WritingTests doesn't mention this case. [1]: https://www.freebsd.org/cgi/man.cgi?query=grep&apropos=0&sektion=1&manpath=FreeBSD+10.3-RELEASE&arch=default&format=html [2]: http://man.openbsd.org/OpenBSD-current/man1/grep.1 [3]: https://docs.oracle.com/cd/E53394_01/html/E54763/grep-1.html
Patch
--- /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t +++ /«BUILDDIR»/mercurial-3.8.2+121-xenial/tests/test-commit-interactive.t.err @@ -899,7 +899,7 @@ > ? > q > EOF - y - \x82\xb1\x82\xcc\x95\xcf\x8dX\x82\xf0\x8bL\x98^(yes) (esc) + Binary file (standard input) matches $ LANGUAGE= #endif