Patchwork [8,of,8] tests: enable import checker for all **.py files

login
register
mail settings
Submitter Yuya Nishihara
Date May 14, 2016, 7:33 a.m.
Message ID <e09aa5efd8b2234b15b6.1463211233@mimosa>
Download mbox | patch
Permalink /patch/15115/
State Accepted
Headers show

Comments

Yuya Nishihara - May 14, 2016, 7:33 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1463203003 -32400
#      Sat May 14 14:16:43 2016 +0900
# Node ID e09aa5efd8b2234b15b6a4fd9aa606ae5bb5b582
# Parent  4bbd966a9ebc63eedbc0c576cab9e8f2e851c8c8
tests: enable import checker for all **.py files

Several known-bad files are excluded as they couldn't be trivially fixed.
That's the same as 99a2bdad0fda.
Augie Fackler - May 23, 2016, 7:47 p.m.
On Sat, May 14, 2016 at 04:33:53PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1463203003 -32400
> #      Sat May 14 14:16:43 2016 +0900
> # Node ID e09aa5efd8b2234b15b6a4fd9aa606ae5bb5b582
> # Parent  4bbd966a9ebc63eedbc0c576cab9e8f2e851c8c8
> tests: enable import checker for all **.py files

Queued these, thanks.

>
> Several known-bad files are excluded as they couldn't be trivially fixed.
> That's the same as 99a2bdad0fda.
>
> diff --git a/tests/test-check-module-imports.t b/tests/test-check-module-imports.t
> --- a/tests/test-check-module-imports.t
> +++ b/tests/test-check-module-imports.t
> @@ -155,8 +155,12 @@ these may expose other cycles.
>  Known-bad files are excluded by -X as some of them would produce unstable
>  outputs, which should be fixed later.
>
> -  $ hg locate 'mercurial/**.py' 'hgext/**.py' 'tests/**.py' \
> +  $ hg locate '**.py' \
>    > 'tests/**.t' \
> +  > -X contrib/debugshell.py \
> +  > -X contrib/win32/hgwebdir_wsgi.py \
> +  > -X doc/gendoc.py \
> +  > -X doc/hgmanpage.py \
>    > -X tests/test-hgweb-auth.py \
>    > -X tests/hypothesishelpers.py \
>    > -X tests/test-ctxmanager.py \
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/tests/test-check-module-imports.t b/tests/test-check-module-imports.t
--- a/tests/test-check-module-imports.t
+++ b/tests/test-check-module-imports.t
@@ -155,8 +155,12 @@  these may expose other cycles.
 Known-bad files are excluded by -X as some of them would produce unstable
 outputs, which should be fixed later.
 
-  $ hg locate 'mercurial/**.py' 'hgext/**.py' 'tests/**.py' \
+  $ hg locate '**.py' \
   > 'tests/**.t' \
+  > -X contrib/debugshell.py \
+  > -X contrib/win32/hgwebdir_wsgi.py \
+  > -X doc/gendoc.py \
+  > -X doc/hgmanpage.py \
   > -X tests/test-hgweb-auth.py \
   > -X tests/hypothesishelpers.py \
   > -X tests/test-ctxmanager.py \