Patchwork [2,of,3,v2] hghave: switch from iteritems to items

login
register
mail settings
Submitter timeless
Date May 11, 2016, 12:54 p.m.
Message ID <12ab239a9766765ae79d.1462971240@gcc2-power8.osuosl.org>
Download mbox | patch
Permalink /patch/15017/
State Accepted
Headers show

Comments

timeless - May 11, 2016, 12:54 p.m.
# HG changeset patch
# User timeless <timeless@mozdev.org>
# Date 1462439546 0
#      Thu May 05 09:12:26 2016 +0000
# Node ID 12ab239a9766765ae79d97eea3a743e2344d1974
# Parent  44c1fb8881423e9f11593bd6687cc687f0d58bbb
# Available At bb://timeless/mercurial-crew
#              hg pull bb://timeless/mercurial-crew -r 12ab239a9766
hghave: switch from iteritems to items

With this, test-hghave.t passes on python 3.

Four features fail because mercurial still is not py3 safe:
absimport
cacheable
hardlink
defaultcacerts

But that will be resolved automatically eventually.
Pierre-Yves David - May 11, 2016, 2:54 p.m.
On 05/11/2016 02:54 PM, timeless wrote:
> # HG changeset patch
> # User timeless <timeless@mozdev.org>
> # Date 1462439546 0
> #      Thu May 05 09:12:26 2016 +0000
> # Node ID 12ab239a9766765ae79d97eea3a743e2344d1974
> # Parent  44c1fb8881423e9f11593bd6687cc687f0d58bbb
> # Available At bb://timeless/mercurial-crew
> #              hg pull bb://timeless/mercurial-crew -r 12ab239a9766
> hghave: switch from iteritems to items

Pushed 1-2, thanks. patch3 was pushed by yuya from the v2 (this on is 
actually a v3)

Thanks for walking the unicode hell-trek.

Patch

diff -r 44c1fb888142 -r 12ab239a9766 tests/hghave
--- a/tests/hghave	Thu May 05 09:07:01 2016 +0000
+++ b/tests/hghave	Thu May 05 09:12:26 2016 +0000
@@ -13,13 +13,13 @@ 
 checks = hghave.checks
 
 def list_features():
-    for name, feature in sorted(checks.iteritems()):
+    for name, feature in sorted(checks.items()):
         desc = feature[1]
         print(name + ':', desc)
 
 def test_features():
     failed = 0
-    for name, feature in checks.iteritems():
+    for name, feature in checks.items():
         check, _ = feature
         try:
             check()