Patchwork [2,of,4,STABLE,V2] debian: add wish to suggests

login
register
mail settings
Submitter Sean Farley
Date May 7, 2016, 6:40 a.m.
Message ID <47bd6b0f7bd6405cf76c.1462603232@laptop.local>
Download mbox | patch
Permalink /patch/14960/
State Accepted
Delegated to: Yuya Nishihara
Headers show

Comments

Sean Farley - May 7, 2016, 6:40 a.m.
# HG changeset patch
# User Sean Farley <sean@farley.io>
# Date 1462076494 25200
#      Sat Apr 30 21:21:34 2016 -0700
# Branch stable
# Node ID 47bd6b0f7bd6405cf76c575760ebc8a69613fff7
# Parent  de8ba4192ec5186ac866e87fe35e894c01224df4
# EXP-Topic docker-ppa
debian: add wish to suggests

Since we're shipping hgk, we need to declare this suggestion.
Sean Farley - May 7, 2016, 7:40 p.m.
Sean Farley <sean@farley.io> writes:

> # HG changeset patch
> # User Sean Farley <sean@farley.io>
> # Date 1462076494 25200
> #      Sat Apr 30 21:21:34 2016 -0700
> # Branch stable
> # Node ID 47bd6b0f7bd6405cf76c575760ebc8a69613fff7
> # Parent  de8ba4192ec5186ac866e87fe35e894c01224df4
> # EXP-Topic docker-ppa
> debian: add wish to suggests
>
> Since we're shipping hgk, we need to declare this suggestion.

As suggested on IRC, this is a bit terse. Here goes a better
description:

debian: add wish to suggests

Debian maintainers already have this and lintian warns us about not
listing 'wish' as a dependency or suggestion so this patch does indeed
just that. The issue, by the way, is that we are shipping hgk (which is
written in tcl/tk) so we should be good citizens and list wish (a meta
package for tcl/tk) as a dependency.

Patch

diff --git a/contrib/debian/control b/contrib/debian/control
--- a/contrib/debian/control
+++ b/contrib/debian/control
@@ -40,10 +40,11 @@  Package: mercurial-common
 Architecture: all
 Depends:
  ${misc:Depends},
  ${python:Depends},
 Recommends: mercurial (= ${source:Version}), ca-certificates
+Suggests: wish
 Breaks: mercurial (<< ${source:Version})
 Replaces: mercurial (<< 2.6.3)
 Description: easy-to-use, scalable distributed version control system (common files)
  Mercurial is a fast, lightweight Source Control Management system designed
  for efficient handling of very large distributed projects.